remove call to waitFor from clock.now and make it async
#691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emizzle
added a commit
that referenced
this pull request
Feb 16, 2024
…)" This reverts commit 591be94.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clock.nowis the last method ofClockthat isn't yet async. The requirement for an asyncclock.nowalready exists in test code, but we've been avoiding making that change and have so far instead resorted to usingwaitForand maintaining a non-async signature. This is however not recommended, and it breaks the profiler.This PR makes the required changes so that clock.now becomes async. The alternative is figuring out a different way to implement the test so that the
waitForcall is no longer required, and then we can kick the can down the road.