Improved blocks.insert() by allowing passing parameters as an object … #2095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zang77
requested review from
neSpecc,
gohabereg,
TatianaFomina and
ilyamore88
as code owners
|
Fixes issue #1817 |
neSpecc
requested changes
Nov 25, 2022
| * @param {number?} index — index where to insert new Block | ||
| * @param {boolean?} needToFocus - flag to focus inserted Block | ||
| * @param replace - pass true to replace the Block existed under passed index | ||
| * @param {NewBlock} newBlock — the block that will be inserted | ||
| */ | ||
| public insert = ( |
There was a problem hiding this comment.
it would be better to save the backward capability
| * @interface NewBlock Describes new block configuration | ||
| */ | ||
|
|
||
| export interface NewBlock { |
There was a problem hiding this comment.
Suggested change
| export interface NewBlock { | |
| export interface BlockInsertionParams { |
|
The solution should save the backward compatibility, but this PR is dropping it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved block.insert() by allowing passing parameters as an object
Fixed some issues commented out from last pr. Set the default parameter for insert.
Added changelog for insert function.
Resolves #1817