Add filtering projects #57
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
temnik15
reviewed
Dec 27, 2020
2 tasks
Shiplayer
suggested changes
Feb 3, 2021
| @@ -9,7 +9,7 @@ import so.codex.hawk.ui.data.UiProject | |||
| class ProjectCallback : DiffUtil.ItemCallback<UiProject>() { | |||
|
|
|||
| override fun areItemsTheSame(oldItem: UiProject, newItem: UiProject): Boolean { | |||
| return oldItem.id == newItem.id | |||
| return oldItem.id === newItem.id | |||
There was a problem hiding this comment.
тут все таки лучше оставить == вместо ===
|
|
||
| // ToDo make class more general for future uses (add generics for example) | ||
| // ToDo add docs | ||
| object FilterProjectUtils { |
There was a problem hiding this comment.
можно сделать обычным классом, создать инстанс во MainViewModel и предоставить этот класс в активити, чтобы установить фильтрацию
| @@ -58,6 +64,7 @@ class MainActivity : AppCompatActivity() { | |||
| Timber.i("show loading") | |||
| } else { | |||
| projectAdapter.submitList(model.projects) | |||
| FilterProjectUtils.filterableList = model.projects | |||
There was a problem hiding this comment.
как то странно получается, сабмитить список в адаптер, потом устанавливать его для фильтрации, где потом все равно будет перезаписан засабмиченный список, почему тогда данную фильтрацию не сделать в MainViewModel?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.