Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(CI): Check starting the app #229

Merged
merged 27 commits into from
Mar 25, 2024
Merged

Feat(CI): Check starting the app #229

merged 27 commits into from
Mar 25, 2024

Conversation

GoldenJaden
Copy link
Contributor

@GoldenJaden GoldenJaden commented Mar 20, 2024

Problem

Not functional code can possibly be delivered to the production enviroment.

Solution

Extend the build check for it to check starting the app as well.

For that case, we start a Postgresql container along with the runner, allowing the app to run properly.

#224

Copy link

github-actions bot commented Mar 20, 2024

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 93.32% (🎯 80%)
⬆️ +0.09%
6854 / 7344
🟢 Statements 93.32% (🎯 80%)
⬆️ +0.09%
6854 / 7344
🟢 Functions 86.25% (🎯 80%)
⬆️ +0.54%
226 / 262
🟢 Branches 90.55% (🎯 80%)
⬇️ -0.19%
345 / 381
File CoverageNo changed files found.
Generated in workflow #629

@TatianaFomina TatianaFomina linked an issue Mar 23, 2024 that may be closed by this pull request
@GoldenJaden GoldenJaden merged commit 45818be into main Mar 25, 2024
6 checks passed
@kloV148 kloV148 deleted the feat/add-start-check branch March 25, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix CI problems
5 participants