Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add noci option #190

Closed
chatelain-io opened this issue Jun 20, 2023 · 3 comments
Closed

Feature request: Add noci option #190

chatelain-io opened this issue Jun 20, 2023 · 3 comments

Comments

@chatelain-io
Copy link

We have a use case where we need to evaluate the next version of a build for short-lived/feature branches and during PR.

It works for feature branches when setting dry_run: true but for PR, we also need to set noCI so semantic-release could evaluate the release and not throwing an error.

image

It would be nice if this action could support any core options.

Regards,

@codfish
Copy link
Owner

codfish commented Jun 20, 2023

@chatelain-io everything work out for you?

@chatelain-io
Copy link
Author

I forked your repo and did the implementation to add the no ci option. But now i'm having another issue when the trigger is on a PR.

Github set the branch to refs/pull/$ID/merge at checkout instead of the branch name the PR was made for. Semantic release is not able to find a releasable branch from that.

image

I think the core option of semantic-release should still (debug, noci, etc) be added to the action so we can workaround some use case.

I've closed this PR since adding the noci option did not work as I expected.

@codfish
Copy link
Owner

codfish commented Jun 21, 2023

yea you'll get that issue with semantic release regardless of implementation or if you use this action. It's not really going to work well on a PR, even for debugging purposes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants