Remove tap grab #63
Closed
Remove tap grab #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confusingly, this also seems to disable Alt-dragging, which I was honestly wondering where it was implemented at this point. |
|
Just saw this, you can see my comment in the issue. It does disable Alt+Drag. Give me a bit to hack on it tomorrow though, I think I can simply avoid grabbing the pointer and allow Alt+Drag to work anyways. I did not use XGrabButton in my original rust worm for sure! That could, actually, solve your issue and allow for border dragging/resizing. Not sure about that... but if it doesn't, at least I can feature-gate it. |
|
Cheers, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #62.
Feel free to close if this behavior is intended, but I'm already running this change locally so it was pretty much 0 effort to create a PR.