Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quickfix tap grab #66

Merged
merged 1 commit into from Apr 10, 2022
Merged

Quickfix tap grab #66

merged 1 commit into from Apr 10, 2022

Conversation

lambdadog
Copy link
Contributor

@lambdadog lambdadog commented Apr 10, 2022

Like I mention in #62, quick-tapping on the titlebar (or borders) will still initiate a drag (since worm apparently isn't catching my buttonrelease with a quick enough tap, as we've discussed), but this stops the majority of the issue since it only grabs if you're not on the window itself and instead clicking on the frame.

Since the vast majority of my intentional clicking is on the window itself this essentially solves the issue, although I'd still like to investigate a true fix on my own time -- other window managers I've used haven't had this problem on my laptop as far as I can tell, so I doubt it's unfixable.

@codic12 codic12 merged commit b798270 into codic12:main Apr 10, 2022
@codic12
Copy link
Owner

codic12 commented Apr 10, 2022

Looks like everything works fine here, thanks! Maybe doing if (client.window != ev.window) and (client.frame.window != ev.window) will fix it even with the titlebar?

Yeah, I'm pretty sure there's some way or the other to fix it, I just have no idea how seeing that I can't test it.

@lambdadog
Copy link
Contributor Author

Maybe doing if (client.window != ev.window) and (client.frame.window != ev.window) will fix it even with the titlebar?

Oh! It might now that you mention it, I was going with the mentality of "the titlebar still needs to get the drag so click-drag on it works", but I forgot that even when I deleted this line entirely titlebar click->dragging still worked.

Of course, you can't really fix it with the borders still, but they're a relatively minor surface that I'm not too worried about, honestly.

@codic12
Copy link
Owner

codic12 commented Apr 10, 2022

Nice, thanks, merged that one too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants