Add active/inactive variants of {close,maximize,minimize}-path
#70
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{close,maximize,minimize}-path
->{close,maximize,minimize}-{active,inactive}-path
I chose to go ahead and set up a ButtonState enum and change the config options to enum indexed arrays, since there's discussion in #57 about extending the possible states further.
Note that while I haven't implemented it in this PR in the interest of doing one thing at a time, it may be reasonable to get rid of ButtonState and instead have just a FocusState (or
focused
boolean value, if you're not concerned about the type system insurance from using a dedicated enum I suppose) on each client and moving every active/inactive switched value to be anarray[FocusState, t]
wheret
is their type. Then when adding hover states you could just have the button paths' config types bearray[FocusState, array[HoverState, string]]
.