Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move configuration defaults from .config files to classes #4291

Closed
emmberk opened this issue Jan 30, 2019 · 3 comments
Closed

Move configuration defaults from .config files to classes #4291

emmberk opened this issue Jan 30, 2019 · 3 comments

Comments

@emmberk
Copy link
Contributor

emmberk commented Jan 30, 2019

Description

  • Classes will be created in a valid state instead of initializing before setting required properties. These classes will also be able to be unit tested in their valid/default state.
  • Features will no longer need to drop .config files, reducing the total number of .config files and simplifying feature definitions. These .config files also cause default configurations to appear as custom configurations in the Admin Console:
    image
  • Downstream projects can drop .config files containing only the properties that are different from the defaults defined in DDF.

Expected behavior:

  • Dropping a .config file that contains not all of the properties for a config should successfully update the properties but keep the defaults for all not-included properties.
  • Configurations appear to set to the defaults in the Admin Console:
    image

Version

2.14.0

Additional Information

none

@emmberk
Copy link
Contributor Author

emmberk commented Mar 4, 2019

ConfigurationApplication still needs to have the default sets when the class is instantiated.

@emmberk
Copy link
Contributor Author

emmberk commented Mar 19, 2020

This is still relevant.

@stale
Copy link

stale bot commented May 18, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within 7 days. Thank you for your contributions.

@stale stale bot added the wontfix label May 18, 2020
@stale stale bot closed this as completed May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
GH Issues Pilot Test
  
In progress
Development

No branches or pull requests

1 participant