Skip to content

Code Review meeting 27 Jan 2016

Brad Hards edited this page Jan 26, 2016 · 2 revisions

IMG-73 architecture work

Probably the main focus. I want to see the way forward to complete support. Lets look at what we have, what we need, and what the gaps are. I'm particularly looking for:

  • how to handle strange bit depths
  • some path to rendering partial files
  • how to handle formats other than ARGB (LUT, monochrome, etc) without making the code ugly.

IMG-51 refactoring

Quick status update.

ImageIO / ImageIO-ext

Making an ImageIO ImageReader for NITF would be an interesting test of our reading API. There is an ongoing project from GeoSolutions (Italy, GeoServer project) called ImageIO-ext (https://github.com/geosolutions-it/imageio-ext). Not well maintained, but perhaps useful for samples. There is a specific NITF project (using Nitro) at https://github.com/geosolutions-it/nitf

This would also be a useful test of the writing API.

Test data

I've started on a GIT LFS repository at https://github.com/codice/imaging-testdata

Has full NITF 2.0 and 2.1 sets from JITC public repo, plus some other stuff we can redistribute.

That will produce reasonably large jars, and will be really slow to check out the git tree. Probably never want to have snapshots - always use a real release (should save downloads).

-rw-rw-r-- 1 bradh bradh 4.6M Jan 26 19:43 ECRG/target/ECRG-0.1-SNAPSHOT.jar
-rw-rw-r-- 1 bradh bradh 2.6M Jan 26 19:43 NitfHRE/target/NitfHRE-0.1-SNAPSHOT.jar
-rw-rw-r-- 1 bradh bradh  24M Jan 26 19:43 NitfJITCSamples20/target/NitfJITCSamples20-0.1-SNAPSHOT.jar
-rw-rw-r-- 1 bradh bradh  34M Jan 26 19:43 NitfJITCSamples21/target/NitfJITCSamples21-0.1-SNAPSHOT.jar
-rw-rw-r-- 1 bradh bradh 820K Jan 26 19:43 NitfRSMJITC/target/NitfRSMJITC-0.1-SNAPSHOT.jar

Would like to discuss how to push this into Codice infrastructure, and switching to using that in 0.3. This will remove the "shared test resources" module from imaging-nitf.

Stuff still to be added:

  • Some samples from AFRL (big, will just do a few)
  • The JITC JPEG2000 set
  • A few files from GDAL, PDAL, Nitro, VTS.

0.3 Changes

Open Pull Request review

We should check what is still open.