Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move edit history ids up a level and close all but the relevant edit #1057

Merged
merged 2 commits into from Jun 8, 2023
Merged

Move edit history ids up a level and close all but the relevant edit #1057

merged 2 commits into from Jun 8, 2023

Conversation

trichoplax
Copy link
Contributor

Fixes #1056.

  • Moves the edit history ids up to the <details> tags
  • Amends the JavaScript to expand the relevant edit in the edit history every time the URL hash changes, rather than only on page load
  • Amends the JavaScript to collapse all the other edits in the edit history every time the URL hash changes

Behaviour is now consistent between Firefox and Chromium.

@cellio cellio requested a review from a team June 7, 2023 20:41
@trichoplax trichoplax force-pushed the trichoplax/1056/expand-edit-history-when-url-hash-changes branch from fe18ae6 to 0db24fe Compare June 8, 2023 00:28
@trichoplax trichoplax requested a review from MoshiKoi June 8, 2023 00:38
MoshiKoi
MoshiKoi approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@MoshiKoi MoshiKoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@cellio cellio merged commit 0c71ee1 into codidact:develop Jun 8, 2023
2 of 4 checks passed
@trichoplax trichoplax deleted the trichoplax/1056/expand-edit-history-when-url-hash-changes branch June 8, 2023 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoshiKoi MoshiKoi MoshiKoi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Edit history does not expand if URL is updated in Firefox
3 participants
@trichoplax @MoshiKoi @cellio