added post count to user posts page

[cellio]

Adds the total number of posts to the user profile's posts page, like on category lists and search results. Addresses https://meta.codidact.com/posts/287868.

With my change:

Before:

(Second try, without the git noise I hope.)

[trichoplax]

Looks good. I've requested 2 minor changes.

[trichoplax]

The opening <div> on line 9 is redundant (it doesn't have a corresponding closing </div>, and doesn't need to be there). It's causing layout problems when adjusting the window width, so at some widths the list of posts jumps up onto the same line as the sorting buttons. Removing line 9 and adjusting the indentation of the following lines should make it clearer which opening <div> matches up with which closing </div>.

The root cause behind this section of code being difficult to reason about is the line <div class="has-color-tertiary-500 category-meta" title="<%= post_count %>">. This div has a title of "post_count", which makes it look like it should be containing only the post count, but it actually contains the sorting buttons too. So its closing </div> is further down the code than expected.

It looks like the code has been based on the similar code in app/views/categories/show.html.erb, which has the same confusing "post_count" on a div that contains more than just the post count. This is also the root cause behind Title text (tooltip/hovertext) shows on unrelated parts of the page. Fixing that bug will make this section of code much easier to read. I recommend against trying to fix it in this pull request - I prefer to keep pull requests focused. Instead I've added an issue (#1109) for that Meta post and mentioned that the fix should be applied to both the category level posts list and the user posts list.

I'm happy with introducing a very minor bug with this pull request, as it's still an overall improvement and the bug is recorded.

Suggested change

	<div>
	<% post_count = @posts.count %>
	<div class="has-color-tertiary-500 category-meta" title="<%= post_count %>">
	<div>
	<%= short_number_to_human post_count, precision: 1, significant: false %>
	<%= 'post'.pluralize(post_count) %> &middot;
	</div>
	<% post_count = @posts.count %>
	<div class="has-color-tertiary-500 category-meta" title="<%= post_count %>">
	<div>
	<%= short_number_to_human post_count, precision: 1, significant: false %>
	<%= 'post'.pluralize(post_count) %> &middot;
	</div>

[trichoplax]

I forgot to mention that the middot (·) used to separate the post count from other buttons is redundant here (since there are no other buttons). I won't add a suggested change yet as I don't want this trivial change to mess up the larger suggestion it would clash with.

Once the larger change is applied (if you're happy with it) I'm happy to make a separate suggestion for the middot, or you could just make a separate commit - whatever's easier.

[cellio]

I had to edit for the stray div anyway, so I got rid of the · while I was there.

I agree that we want a general fix for the misplaced tooltip text and should do it separately.