239 after login redirect to the original page #1131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It does not seem there is a good way to split off these methods (only one usage site, not worth to extract into separate functionality).
ArtOfCode-
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way this works is by always storing the last url the user visited, expect if that was any URL we want to ignore (AJAX, file/image, edits, sign-in pages, ...). If a user then presses sign in and signs in, they are redirected back to the last stored location. (It makes use of the fact that Rails uses session cookies also for non-signed-in users to identify them across different requests.)
Normal devise sign ins already make use of the location, thus I only had to edit the redirects for our customized sign-in endpoints (mobile sign in and 2FA).
When doing a 2FA sign in (email based), you first sign in with email and password, then it sends you back to the page you were looking at before going to the sign in, while asking you to check your mail. The link in the email will again send you to that same page when used.
Fixes #239