Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a notice when tags and attributes are rejected #1203

Merged
merged 5 commits into from Oct 23, 2023

Conversation

MoshiKoi
Copy link
Member

Resolves #1140

image

Currently waiting for a help article to be created so I can link to that instead of my own post.

@cellio
Copy link
Member

cellio commented Oct 2, 2023

Is someone working on that help article? If not, what do we need -- an edit to the formatting topic, a new topic, something else?

@MoshiKoi
Copy link
Member Author

MoshiKoi commented Oct 3, 2023

I don't know if anyone is working on it; pinging @codidact/documentation

@MoshiKoi
Copy link
Member Author

MoshiKoi commented Oct 3, 2023

I'm not sure what exactly is needed; I think any of your suggestions would work fine. I'll leave it to the writers to figure it out 🙂

@superplane39
Copy link
Member

Help article written; it currently exists on Meta and #1212 adds it to seeds for the network

@MoshiKoi MoshiKoi marked this pull request as ready for review October 5, 2023 01:16
@cellio cellio requested a review from a team October 5, 2023 01:18
@Oaphi Oaphi added the area: html/css/js Changes to front-end code label Oct 21, 2023
Copy link
Member

@Oaphi Oaphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a small fix & a minor expansion for the PR (someone else might want to review them), so other than that - LGTM! Played around with the changes locally, seems to be working perfectly fine.

@cellio
Copy link
Member

cellio commented Oct 22, 2023

@MoshiKoi can you review the latest changes and let us know if you're happy with them?

@MoshiKoi
Copy link
Member Author

Looks good to me

@MoshiKoi MoshiKoi merged commit be6f490 into codidact:develop Oct 23, 2023
7 checks passed
@MoshiKoi MoshiKoi deleted the editor-improvements branch November 6, 2023 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: html/css/js Changes to front-end code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inform the user of disallowed HTML
4 participants