Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent keyboard events with modifier keys from triggering shortcuts #1222

Merged
merged 3 commits into from
Nov 12, 2023

Conversation

Oaphi
Copy link
Member

@Oaphi Oaphi commented Oct 22, 2023

Closes #1206.

Additional issue I've noticed is that the "a" shortcut no longer works (causing a runtime error) as there's no element with the answer_body_markdown id (post fields are currently all id'd as post_body_markdown). Fixing that is outside of the scope of the PR - let's tackle it separately.

@Oaphi Oaphi added area: html/css/js Changes to front-end code complexity: easy Issues that should take limited effort to resolve/fix/build. labels Oct 22, 2023
@Oaphi Oaphi requested a review from a team October 22, 2023 01:27
@Oaphi Oaphi self-assigned this Oct 25, 2023
Copy link
Contributor

@Taeir Taeir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a minor suggestion for a function rename, but otherwise the changes look good to me!

app/assets/javascripts/keyboard_tools.js Show resolved Hide resolved
@Taeir Taeir merged commit 051adf7 into develop Nov 12, 2023
7 checks passed
@Taeir Taeir deleted the 0valt/1206/untrap-modifier-keys branch November 12, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: html/css/js Changes to front-end code complexity: easy Issues that should take limited effort to resolve/fix/build.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyboard shortcuts shouldn't trap ctrl-(letter)
2 participants