Dynamically update post score tooltip (#1207) #1224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oaphi
added
area: ruby
Taeir
reviewed
Nov 11, 2023
Applied from suggestion - part 1 Co-authored-by: Taico Aerts <t.v.aerts@tudelft.nl>
Applied from suggestion - part 2 Co-authored-by: Taico Aerts <t.v.aerts@tudelft.nl>
Special thanks to @Taeir for a cleaner & optimal way of getting the updated state
Taeir
approved these changes
Nov 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures the post score tooltips are updated on vote success. I opted for adding a new
scorefield to the success response (re-finding the post is needed to get the updated score after therecalc_scoremethod is run - if anyone has a better idea for doing so, I'd appreciate that).Screencast.from.23.10.2023.04.16.50.webm