Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add score tooltips for post list vote counts #1226

Merged
merged 1 commit into from Oct 25, 2023
Merged

Add score tooltips for post list vote counts #1226

merged 1 commit into from Oct 25, 2023

Conversation

Oaphi
Copy link
Member

@Oaphi Oaphi commented Oct 23, 2023

Closes #1097

This PR adds a very minor fix for missing score tooltips on vote counts in post lists:

Screencast.from.23.10.2023.08.03.34.webm

@Oaphi Oaphi self-assigned this Oct 23, 2023
@Oaphi Oaphi requested a review from a team October 23, 2023 05:04
@Oaphi Oaphi added the area: ruby Changes to server-side code label Oct 23, 2023
trichoplax
trichoplax approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@trichoplax trichoplax left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

I've tested this with lists of questions, lists of articles, and lists containing both questions and articles, and all work correctly.

@cellio cellio merged commit e5574b9 into develop Oct 25, 2023
7 checks passed
@cellio cellio deleted the 0valt/1097/score-tooltips-for-post-lists branch October 25, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trichoplax trichoplax trichoplax approved these changes

Assignees

@Oaphi Oaphi

Labels
area: ruby Changes to server-side code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show question score on hover in post lists, like on posts
3 participants
@Oaphi @trichoplax @cellio