Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify fields on password-change form #929

Merged
merged 2 commits into from Jan 3, 2023
Merged

Conversation

cellio
Copy link
Member

@cellio cellio commented Jan 2, 2023

Re: https://meta.codidact.com/posts/287649

Changes the order to: current pwd, new pwd, confirm new pwd, and also clarifies some labels.

screenshot

While looking for the right source file, I also came across app/views/devise/passwords/edit.html.erb, which doesn't match any page I can find from the user profile on a live site. Is that file used? Where?

@cellio cellio requested a review from a team January 2, 2023 20:02
@cellio
Copy link
Member Author

cellio commented Jan 2, 2023

Rubocop is unhappy with files I didn't change. Am I supposed to try to correct that?

@ArtOfCode- ArtOfCode- merged commit 0dccad2 into develop Jan 3, 2023
@ArtOfCode- ArtOfCode- deleted the cellio/change-pwd-order branch January 3, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants