Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only check for user preferences if signed in #951

Merged
merged 16 commits into from Jan 17, 2023
Merged

Only check for user preferences if signed in #951

merged 16 commits into from Jan 17, 2023

Commits on Jan 9, 2023

  1. Convert 'else if' to 'if' because it depends on data from the previou… 

    …s 'if' block
    @trichoplax
    trichoplax committed Jan 9, 2023
    Copy the full SHA
    b3bc0d4 View commit details
    Browse the repository at this point in the history

  2. Remove check for old preferences schema from over 2 years ago

    @trichoplax
    trichoplax committed Jan 9, 2023
    Copy the full SHA
    8be131c View commit details
    Browse the repository at this point in the history

  3. Add early return for most frequent case to reduce processing

    @trichoplax
    trichoplax committed Jan 9, 2023
    Copy the full SHA
    4ba7d6a View commit details
    Browse the repository at this point in the history

  4. Remove null check that is now redundant due to early return

    @trichoplax
    trichoplax committed Jan 9, 2023
    Copy the full SHA
    aab2313 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2023

  1. Improve comment to state local variable contains preferences

    @trichoplax
    trichoplax committed Jan 10, 2023
    Copy the full SHA
    c0b42f4 View commit details
    Browse the repository at this point in the history

  2. Reject only null & undefined, rather than all falsy local preferences

    @trichoplax
    trichoplax committed Jan 10, 2023
    Copy the full SHA
    0b5b4b5 View commit details
    Browse the repository at this point in the history

  3. Remove 'if' block made redundant by early returns

    @trichoplax
    trichoplax committed Jan 10, 2023
    Copy the full SHA
    4949c7f View commit details
    Browse the repository at this point in the history

  4. Store preferences on QPixel rather than window ('this')

    @trichoplax
    trichoplax committed Jan 10, 2023
    Copy the full SHA
    a1bb304 View commit details
    Browse the repository at this point in the history

  5. Suppress preferences retrieval when user is not signed in

    @trichoplax
    trichoplax committed Jan 10, 2023
    Copy the full SHA
    94ba47e View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2023

  1. Extract duplicated localStorage preferences code into a function

    @trichoplax
    trichoplax committed Jan 11, 2023
    Copy the full SHA
    33abac3 View commit details
    Browse the repository at this point in the history

  2. Use unique localStorage key per user to avoid corruption

    @trichoplax
    trichoplax committed Jan 11, 2023
    Copy the full SHA
    306a554 View commit details
    Browse the repository at this point in the history

  3. Make 'if' explicit and include mandatory braces for code standards

    @trichoplax
    trichoplax committed Jan 11, 2023
    Copy the full SHA
    1bba8a3 View commit details
    Browse the repository at this point in the history

  4. Add the commas I forgot between new functions in QPixel object

    @trichoplax
    trichoplax committed Jan 11, 2023
    Copy the full SHA
    81caadb View commit details
    Browse the repository at this point in the history

  5. Change preference function to use early return

    @trichoplax
    trichoplax committed Jan 11, 2023
    Copy the full SHA
    6a4b147 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2023

  1. Extract common code into separate functions

    @trichoplax
    trichoplax committed Jan 12, 2023
    Copy the full SHA
    eba672d View commit details
    Browse the repository at this point in the history

  2. Add JavaScript documentation comments for new functions

    @trichoplax
    trichoplax committed Jan 12, 2023
    Copy the full SHA
    4582d43 View commit details
    Browse the repository at this point in the history