Skip to content
This repository has been archived by the owner on May 4, 2023. It is now read-only.

#221: Added JavaScript and TypeScript language support. #224

Merged
merged 6 commits into from
Dec 15, 2022

Conversation

picimako
Copy link
Contributor

@picimako picimako commented Dec 13, 2022

Changes:

  • Added Rosie support for the JavaScript and TypeScript languages.
  • Moved all Rosie language support logic to the RosieLanguageSupport class, so that future language support additions will be easier.

Notes

…e support logic to the RosieLanguageSupport class.
@picimako picimako requested a review from juli1 December 13, 2022 07:14
Copy link
Contributor

@dastrong-codiga dastrong-codiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please add the extra elementChecked types I've mentioned in Slack.
  • Change the language for Rosie from JS for TS file, to be TS.
    • please ensure any exceptions from Rosie are caught (as Rosie does not support Typescript currently)

@dastrong-codiga dastrong-codiga merged commit bdb7ac2 into main Dec 15, 2022
@dastrong-codiga dastrong-codiga deleted the rosie-javascript-support branch December 15, 2022 17:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants