Update configuration.md #531
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericgaspar
commented
Oct 10, 2020
ericgaspar
commented
- Minor formatting typo
Minor formatting typo
DerMolly
approved these changes
Oct 11, 2020
|
Thanks this looks great, but you did not sign your commit. When you fix this I'll merge your PR. Here's a how to https://github.com/codimd/server/pull/531/checks?check_run_id=1236162929 |
Minor formatting typo Signed-off-by: ericgaspar <junk.eg@free.fr>
davidmehren
approved these changes
Oct 11, 2020
|
mmmh I can't figure out how to sign-off this commit... I follow the how-to but I get an authentication error o.O |
davidmehren
added a commit
that referenced
this pull request
Oct 12, 2020
|
Alright, I merged your contribution manually to fix the duplicated commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.