Skip to content
This repository has been archived by the owner on Apr 18, 2023. It is now read-only.

npm and pip api changes #14

Merged
merged 11 commits into from
Jan 10, 2023
Merged

npm and pip api changes #14

merged 11 commits into from
Jan 10, 2023

Conversation

harshraj8843
Copy link
Contributor

@harshraj8843 harshraj8843 commented Jan 9, 2023

What's being changed:

  • fetch data from pip and npm API
  • update links and texts
  • migrate from getServerSideProps to getStaticProps with revalidation of 60 seconds
  • remove dateRef as we are getting the latest update time from npm and pip API
  • format files
  • converge URLs to siteMetaData
  • Add Comment component

@vercel
Copy link

vercel bot commented Jan 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
open-tools ✅ Ready (Inspect) Visit Preview Jan 10, 2023 at 3:14PM (UTC)

@harshraj8843
Copy link
Contributor Author

Live editor is disabled for now, i am finding a way to use it successfully

@harshraj8843
Copy link
Contributor Author

Hey @0ME9A

Can you please add a copy to the clipboard button on hover for

Screenshot from 2023-01-09 13-40-44

Screenshot from 2023-01-09 13-40-34

Screenshot from 2023-01-09 13-40-48

with revalidation of 60 seconds
@harshraj8843
Copy link
Contributor Author

Screenshot from 2023-01-09 15-44-41

@harshraj8843
Copy link
Contributor Author

Warning There is an issue with the dark mode toggle button

On each page refresh, it has to be toggle twice to start working

@0ME9A
Copy link
Collaborator

0ME9A commented Jan 9, 2023

not worry I see it😀

Copy link
Collaborator

@0ME9A 0ME9A left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, My lack of knowledge is now embarrassing me😔

@0ME9A
Copy link
Collaborator

0ME9A commented Jan 9, 2023

One more thing I've noticed is that you changed the name open-tools to codinasion-tools.🤔

@harshraj8843
Copy link
Contributor Author

Yes because open-tool and opentoolshub is very confusing and we need something such that both npm and pip package name will be same

@harshraj8843
Copy link
Contributor Author

It is not necessary that the project name should be codinasion-tools. I did it just because it was available

Do you have any suggestion?

@harshraj8843
Copy link
Contributor Author

Wow, My lack of knowledge is now embarrassing me

Are you kidding me 😂

@harshraj8843
Copy link
Contributor Author

Can we merge this PR 🤔

@0ME9A
Copy link
Collaborator

0ME9A commented Jan 10, 2023

Can we merge this PR 🤔

Wait I am committing in a few hours which includes theme error and copy text btn.

@0ME9A
Copy link
Collaborator

0ME9A commented Jan 10, 2023

Now it's time to merge🚀

@0ME9A 0ME9A closed this Jan 10, 2023
@harshraj8843 harshraj8843 reopened this Jan 10, 2023
@harshraj8843
Copy link
Contributor Author

Why closed 🤔

@harshraj8843
Copy link
Contributor Author

harshraj8843 commented Jan 10, 2023

There is an issue with the tool page ([tid].js) footer Top Tools. Don't know why 🤔

On normal navigation, it works fine but if we reload the page or open the tool page directly then it shows an empty list

👉🏻 https://open-tools-git-website-patch-codinasion.vercel.app/tools/convert-days-to-seconds

Screenshot from 2023-01-10 20-46-19

Screenshot from 2023-01-10 20-46-26

@harshraj8843
Copy link
Contributor Author

Merging this PR for now

@harshraj8843 harshraj8843 merged commit e0484b0 into master Jan 10, 2023
@0ME9A
Copy link
Collaborator

0ME9A commented Jan 10, 2023

There is an issue with the tool page ([tid].js) footer Top Tools. Don't know why 🤔

On normal navigation, it works fine but if we reload the page or open the tool page directly then it shows an empty list

👉🏻 https://open-tools-git-website-patch-codinasion.vercel.app/tools/convert-days-to-seconds

Screenshot from 2023-01-10 20-46-19

Screenshot from 2023-01-10 20-46-26

It's happening because footer is not a part of [tid] comp it is part of layoutX comp it means we have to send related tools data into footer with the help of useContext hook and context hook will send the data to the footer and that's it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants