This repository has been archived by the owner on May 31, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👋🏻 Hey @KaptainCS3 💖 Thanks for opening this pull request 💖 This PR will be reviewed and merged shortly. |
victoriacheng15
previously requested changes
Sep 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of things:
- c, cpp, Python, kotlin, JavaScript, and php file names are not following the naming convention. Please refer to the naming convention in the language specific issues.
- I got an error on cpp function
Thank you!
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. Support this project by giving it a star ⭐. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
C
c related
C++
cpp related
hacktoberfest-accepted
Hacktoberfest 2022 acceptable PR
JavaScript
js related
Kotlin
kotlin related
PHP
php related
Python
python related
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
Closes codinasion/codinasion#4
Closes codinasion/codinasion#6
Closes codinasion/codinasion#11
Closes codinasion/codinasion#13
Closes codinasion/codinasion#15
Closes codinasion/codinasion#16
What's being changed: