Skip to content
This repository has been archived by the owner on May 31, 2023. It is now read-only.

addTwoMatrices #6151

Merged
merged 11 commits into from
Feb 5, 2023
Merged

addTwoMatrices #6151

merged 11 commits into from
Feb 5, 2023

Conversation

weaam88
Copy link
Contributor

@weaam88 weaam88 commented Jan 31, 2023

Why:

Closes codinasion/codinasion#3454

What's being changed: added implementation in type script to addTwoMatrices

@weaam88 weaam88 requested review from a team, harshraj8843 and grraghav120 and removed request for a team January 31, 2023 21:01
@codinasion-bot
Copy link

👋🏻 Hey @weaam88

💖 Thanks for opening this pull request 💖

This PR will be reviewed and merged shortly.

@vercel
Copy link

vercel bot commented Jan 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated
program-api ⬜️ Ignored (Inspect) Feb 5, 2023 at 5:50AM (UTC)
program-website ⬜️ Ignored (Inspect) Feb 5, 2023 at 5:50AM (UTC)

@codinasion-bot codinasion-bot bot added the triage Waiting for review label Jan 31, 2023
Copy link
Contributor

@anandfresh anandfresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weaam88 please add the issue it to this PR

@weaam88 weaam88 requested review from anandfresh and removed request for harshraj8843 and grraghav120 February 3, 2023 13:05
@weaam88
Copy link
Contributor Author

weaam88 commented Feb 3, 2023

@weaam88 please add the issue it to this PR

did i did it write?

@anandfresh
Copy link
Contributor

@weaam88 please add the issue it to this PR

did i did it write?

No , you have to add the issue in under Why with Closes keyword.
Refer the below PR for example : #6171

While creating PR , you have everything including the Closes keyowrd , only thing you need to add is the issues id in the place holder

@weaam88
Copy link
Contributor Author

weaam88 commented Feb 4, 2023

@weaam88 please add the issue it to this PR

did i did it write?

No , you have to add the issue in under Why with Closes keyword. Refer the below PR for example : #6171

While creating PR , you have everything including the Closes keyowrd , only thing you need to add is the issues id in the place holder

ok, done

@anandfresh
Copy link
Contributor

@weaam88 please add the issue it to this PR

did i did it write?

No , you have to add the issue in under Why with Closes keyword. Refer the below PR for example : #6171
While creating PR , you have everything including the Closes keyowrd , only thing you need to add is the issues id in the place holder

ok, done

@weaam88 You have added the PR ID , but you should add the issue ID.

Copy link
Contributor

@harshraj8843 harshraj8843 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing 🤗

@harshraj8843 harshraj8843 merged commit e803ede into codinasion:master Feb 5, 2023
@codinasion-bot
Copy link

codinasion-bot bot commented Feb 5, 2023

Thanks very much for contributing!

Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

Support this project by giving it a star ⭐.

Join Our Community

If you're looking for your next contribution, check out our help wanted issues

@codinasion-bot codinasion-bot bot removed the triage Waiting for review label Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write a TypeScript program to add two matrices
3 participants