-
-
Notifications
You must be signed in to change notification settings - Fork 519
Conversation
👋🏻 Hey @weaam88 💖 Thanks for opening this pull request 💖 This PR will be reviewed and merged shortly. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@weaam88 please add the issue it to this PR
did i did it write? |
No , you have to add the issue in under Why with Closes keyword. While creating PR , you have everything including the Closes keyowrd , only thing you need to add is the issues id in the place holder |
ok, done |
@weaam88 You have added the PR ID , but you should add the issue ID. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing 🤗
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. Support this project by giving it a star ⭐. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
Closes codinasion/codinasion#3454
What's being changed: added implementation in type script to addTwoMatrices