This repository has been archived by the owner on May 31, 2023. It is now read-only.
Convert octal to binary ruby #6215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fukurokudzu
requested review from
a team,
anandfresh and
harshraj8843
and removed request for
a team
|
👋🏻 Hey @Fukurokudzu 💖 Thanks for opening this pull request 💖 This PR will be reviewed and merged shortly. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
anandfresh
approved these changes
Feb 10, 2023
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. Support this project by giving it a star ⭐. If you're looking for your next contribution, check out our help wanted issues ⚡ |
NicholasCloud4
pushed a commit
to NicholasCloud4/program
that referenced
this pull request
Feb 10, 2023
* Closes #4515 * All helpers methods should be private
NicholasCloud4
added a commit
to NicholasCloud4/program
that referenced
this pull request
Feb 10, 2023
* Closes #4515 * All helpers methods should be private
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
Closes codinasion/codinasion#3408
What's being changed:
Converts octal number to binary
Comments:
There's much shorter variant with
.to_sand.to_imethods, but it's non-obvious. I used more conservative approach and recursion for decimal to binary conversion.