Used Space Progress issue fixed #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @hardik0899, for opening the pull request! 🙌 One of our mentors will review the pull request soon. ✅ Star ⭐ this project and tweet 🐦 about your contributions. |
|
@aggarwalpulkit596 Bhayia pls have a look whenever you are free. |
aggarwalpulkit596
suggested changes
Jun 9, 2020
| @@ -102,6 +99,10 @@ class SettingsActivity : BaseCBActivity() { | |||
| it | |||
| ).readableFileSize() | |||
| }) | |||
| val usedSpace : Double = file?.let { folderSize(it) }!!.toDouble() / 1048576 | |||
There was a problem hiding this comment.
Can you not use !! operator
|
@aggarwalpulkit596 done the changes pls review once again the latest commit |
|
Congratualtions @hardik0899, your pull request is merged! 🎉 Thanks for your contributions and participating in BOSS 2020. 🙌 You can claim your bounty points here. 💰 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #696
Progress Bar was not showing the space used after downloading the videos from the courses. But now its fixed and I have tested it on 3 different devices. Its working awesome :)
Screenshots for the change:
