Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Bot not greeting new PRs #380

Closed
YashKumarVerma opened this issue May 28, 2020 · 2 comments · Fixed by #381
Closed

Github Bot not greeting new PRs #380

YashKumarVerma opened this issue May 28, 2020 · 2 comments · Fixed by #381

Comments

@YashKumarVerma
Copy link
Contributor

The bot is not sending a welcome message for the PR which it earlier used to do.

Code for it:

boss/bot/index.js

Lines 26 to 45 in 68a64a8

app.on('pull_request.opened', async context => {
const pr = context.payload.pull_request
if(adminUsernames.includes(issue.user.login)){
app.log(`Ignoring new pr ${pr.id} opened by admin ${pr.user.login}`)
return
}
if (!pr.closed_at) {
app.log(`Pull Request Opened: ${pr.id}`)
const comment = context.issue({
body: `Thanks @${pr.user.login}, for opening the pull request! 🙌
One of our mentors will review the pull request soon. ✅
Star ⭐ this project and [tweet](https://twitter.com/intent/tweet?text=I%20am%20contributing%20to%20open%20source%2C%20join%20me%20in%20participating%20in%20%23BOSS2020%20%40CodingBlocksIn%20https%3A%2F%2Fcb.lk%2Fboss%0A) 🐦 about your contributions.`
})
return context.github.issues.createComment(comment)
}
})

Earlier:
image

Now:
image

@boss-contributions-bot
Copy link

Thanks @YashKumarVerma, for raising the issue! 🙌

One of our mentors will revert on this soon. ✅

Star ⭐ this project and tweet 🐦 about BOSS 2020.

@thenamankumar
Copy link
Contributor

Good work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants