Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #299 - Fixed edit functionality which wasnt functional #304

Closed
wants to merge 4 commits into from
Closed

fixes #299 - Fixed edit functionality which wasnt functional #304

wants to merge 4 commits into from

Conversation

ankiiitraj
Copy link
Contributor

@ankiiitraj ankiiitraj commented May 18, 2020

Fixed #299
Problem was update function was configured for only admin.
Now the functionality to edit and save works fine

@boss-contributions-bot
Copy link

Thanks @ankiiitraj, for opening the pull request! 🙌

One of our mentors will review the pull request soon. ✅

Star ⭐ this project and tweet 🐦 about your contributions.

@ankiiitraj
Copy link
Contributor Author

ankiiitraj commented May 18, 2020

Hi @hereisnaman || @hereisnaman , Kindly review this PR and let me know if something is to be done. Thanks

Follow up:
Hi mentors, If something more is to be done let me know.

@ankiiitraj
Copy link
Contributor Author

Kindly review this too @hereisnaman

@thenamankumar
Copy link
Contributor

@ankiiitraj no need to enable update for the urls. Rather disable the input fields in the edit form on frontend.

@ankiiitraj
Copy link
Contributor Author

ankiiitraj commented May 22, 2020

@hereisnaman Done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Save button do not saves the changes on Edit page
2 participants