Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pagination refactor #403

Merged
merged 1 commit into from
Jul 24, 2020
Merged

pagination refactor #403

merged 1 commit into from
Jul 24, 2020

Conversation

rahgurung
Copy link
Contributor

@rahgurung rahgurung commented Jun 5, 2020

THIS PR closes 2 BOUNTY ISSUES

closes #397 closes #398
Fixes

  1. Issue with leaderboard #397
  2. Error when leaderboard empty #398
  3. Clicking on Last doesn't take you on last page.
  4. ... feature wasn't working even though code was there.

I removed Last and First button here because first and last page links are always there. Let me know if you want to have Next and Prev text instead of those arrows.

Screenshots:
Screenshot from 2020-06-05 22-22-33
Screenshot from 2020-06-05 22-23-03

@boss-contributions-bot
Copy link

Thanks @gurrrung, for opening the pull request! 🙌

One of our mentors will review the pull request soon. ✅

Star ⭐ this project and tweet 🐦 about your contributions.

@rahgurung
Copy link
Contributor Author

No volunteer I guess, Can I self test this and comment the detailed report here with screenshots?

Will I get the testing bounty also if I test my PR myself?

@thenamankumar
Copy link
Contributor

No volunteer I guess, Can I self test this and comment the detailed report here with screenshots?

Will I get the testing bounty also if I test my PR myself?

You won't get extra bounty for it but will be much appreciated.

@YashKumarVerma
Copy link
Contributor

I'd be helping in testing if needed.

@thenamankumar
Copy link
Contributor

I'd be helping in testing if needed.

The author of the PR won't but others will.

@rahgurung
Copy link
Contributor Author

I'd be helping in testing if needed.

Go ahead.

@amit2699 amit2699 mentioned this pull request Jun 12, 2020
@thenamankumar
Copy link
Contributor

@YashKumarVerma are you testing this? What is the status?

@rahgurung
Copy link
Contributor Author

Testing reports:
Total 7 pages, I'm on page 1
Screenshot from 2020-06-17 21-20-53

Total 7 pages, I'm on page 3 (if you are expecting ... here, it is not there and this is inbuilt in the library, actually, we can just show the whole pagination instead of showing two ...s.
Screenshot from 2020-06-17 21-21-38

Total 7 pages, I'm on page 7
Screenshot from 2020-06-17 21-22-26

Total 0 pages, #398
Screenshot from 2020-06-17 21-24-29

Total 12 pages I'm on the first page
Screenshot from 2020-06-17 21-48-08

Total 12 pages I'm on 6th page
Screenshot from 2020-06-17 21-48-58

Total 12 pages I'm on last page
Screenshot from 2020-06-17 21-49-26

@rahgurung
Copy link
Contributor Author

Review ping

@rahgurung
Copy link
Contributor Author

It's ready to be merged @championswimmer @hereisnaman

@thenamankumar
Copy link
Contributor

@gurrrung good work. Looks good!

@thenamankumar thenamankumar merged commit 97e0e8e into coding-blocks:master Jul 24, 2020
@boss-contributions-bot
Copy link

Congratualtions @gurrrung, your pull request is merged! 🎉

Thanks for your contributions and participating in BOSS 2020. 🙌

You can claim your bounty points here. 💰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when leaderboard empty Issue with leaderboard
3 participants