-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pagination refactor #403
pagination refactor #403
Conversation
Thanks @gurrrung, for opening the pull request! 🙌 One of our mentors will review the pull request soon. ✅ Star ⭐ this project and tweet 🐦 about your contributions. |
No volunteer I guess, Can I self test this and comment the detailed report here with screenshots? Will I get the testing bounty also if I test my PR myself? |
You won't get extra bounty for it but will be much appreciated. |
I'd be helping in testing if needed. |
The author of the PR won't but others will. |
Go ahead. |
@YashKumarVerma are you testing this? What is the status? |
Testing reports: Total 7 pages, I'm on page 3 (if you are expecting Total 0 pages, #398 Total 12 pages I'm on the first page |
Review ping |
It's ready to be merged @championswimmer @hereisnaman |
@gurrrung good work. Looks good! |
Congratualtions @gurrrung, your pull request is merged! 🎉 Thanks for your contributions and participating in BOSS 2020. 🙌 You can claim your bounty points here. 💰 |
THIS PR closes 2 BOUNTY ISSUES
closes #397 closes #398
Fixes
...
feature wasn't working even though code was there.I removed
Last
andFirst
button here because first and last page links are always there. Let me know if you want to have Next and Prev text instead of those arrows.Screenshots:
![Screenshot from 2020-06-05 22-22-33](https://user-images.githubusercontent.com/30543444/83903072-24e49e80-a77b-11ea-83fb-35542e8de748.png)
![Screenshot from 2020-06-05 22-23-03](https://user-images.githubusercontent.com/30543444/83903103-32018d80-a77b-11ea-9bd5-d813fbbf34f5.png)