Skip to content

Commit

Permalink
Merge pull request #527 from coding-blocks/revamp-UI-fixes
Browse files Browse the repository at this point in the history
Revamp ui fixes
  • Loading branch information
abhishek97 committed Mar 3, 2020
2 parents 365eb0b + 7f63fae commit 999415c
Show file tree
Hide file tree
Showing 11 changed files with 61 additions and 72 deletions.
4 changes: 2 additions & 2 deletions app/pods/attempt/content/code-challenge/template.hbs
@@ -1,5 +1,5 @@
{{#if problem.id}}
<div class="p-5 mb-5 border-card white border-none bg-grey-darker">
<div class="p-md-5 p-4 mb-5 border-card white border-none bg-grey-darker">
<WTabNav
@inactiveClass="white"
@tabs={{tabs}}
Expand All @@ -16,7 +16,7 @@
@codeChallenge={{codeChallenge}}
@problem={{problem}} />
{{else}}
<div class="p-5 mb-5 border-card white border-none bg-grey-darker">
<div class="p-md-5 p-4 mb-5 border-card white border-none bg-grey-darker">
<div class="t-align-c">
<FaIcon @icon="info-circle" @size="4" class="grey" />
</div>
Expand Down
2 changes: 1 addition & 1 deletion app/pods/attempt/content/template.hbs
Expand Up @@ -6,7 +6,7 @@
<div>
{{outlet}}
</div>
<div class="d-md-block d-none">
<div class="d-lg-block d-none">
<Player::PlayerTabs />
</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion app/pods/attempt/template.hbs
Expand Up @@ -43,7 +43,7 @@
{{outlet}}
</div>
</div>
<div class="d-md-none d-block">
<div class="d-lg-none d-block px-4">
{{#if player.isActive}}
<Player::PlayerTabs />
{{/if}}
Expand Down
@@ -1,5 +1,5 @@
<div class="border-card c-code-card p-0 border-none mb-5">
<div class="header row px-5 py-4 justify-content-between align-items-center m-0">
<div class="header row px-md-5 px-4 py-4 justify-content-between align-items-center m-0">
<div class="col-3 p-0">
<span class="font-sm extra-bold">Code Editor</span>
</div>
Expand Down Expand Up @@ -34,15 +34,15 @@
/>
</div>
{{/if}}
<div class="footer pt-4 pb-5 px-5 input-div">
<div class="row justify-content-between align-items-center">
<div class="col-4 white extra-bold p-0 pointer" {{action toggleCustomInput}}>
<div class="footer pt-4 pb-5 px-md-5 px-4 input-div">
<div class="row justify-content-sm-between justify-content-center align-items-center no-gutters">
<div class="col-sm-4 col-12 white extra-bold pointer t-align-sm-l t-align-c" {{action toggleCustomInput}}>
<FaIcon @icon={{if customInputOpen "angle-up" "angle-down"}} />
<span>Provide Custom Input</span>
</div>
<div>
<div class="mt-sm-0 mt-3">
<button
class="button-dashed button-orange ml-3 mr-1"
class="button-dashed button-orange mx-sm-3 mr-3"
disabled={{judgeTaskGroup.isRunning}}
{{action (perform runCodeTask)}}>

Expand All @@ -54,7 +54,7 @@

</button>
<button
class="button-solid button-orange mr-3 ml-1"
class="button-solid button-orange"
disabled={{judgeTaskGroup.isRunning}}
{{action (perform submitCodeTask)}}>

Expand Down
@@ -1,10 +1,10 @@
<div class="col-md-5 col-6">
<div class="col-lg-4 col-md-6 pl-md-3 mt-md-0 mt-4">
<div class="font-normal">Course Progress</div>
<div class="mt-3">
<MyCoursesList::ProgressBar @percent={{progressPercent}} />
</div>
</div>
<div class="col-md-3 col-12 mt-md-0 mt-3">
<div class="col-lg-4 col-12 mt-lg-0 mt-4 pl-lg-3">
<div class="row no-gutters justify-content-around align-items-center">
<LinkTo
@route="classroom.timeline.overview"
Expand Down
6 changes: 4 additions & 2 deletions app/pods/components/my-courses-list/progress-bar/template.hbs
@@ -1,2 +1,4 @@
<progress value={{percent}} max="100" class="d-inline-block w-80 {{progressBarClass}}"></progress>
<span class="bold ml-3">{{percent}}%</span>
<div class="d-flex align-items-center">
<progress value={{percent}} max="100" class="flex-1 {{progressBarClass}}"></progress>
<span class="bold ml-3">{{percent}}%</span>
</div>
@@ -1,22 +1,18 @@
<div class="col-md-5 col-6">
<div class="col-lg-5 col-md-6 pl-md-3 mt-md-0 mt-4">
<div class="font-normal">Course Progress</div>
<div class="mt-3">
<MyCoursesList::ProgressBar @percent={{progressPercent}} />
</div>
</div>
<div class="col-md-3 col-12 mt-md-0 mt-3">
<div class="col-lg-3 col-12 mt-lg-0 mt-4 pl-lg-3">
<div class="row no-gutters justify-content-around align-items-center">
<a href="#" class="font-normal {{fontClassName}}"> {{progressText}} </a>
<LinkTo
@route="classroom.timeline.overview"
@models={{array run.course.id run.id}}
@tagName="button"
class="button-orange button-solid"
>
<LinkTo @route="classroom.timeline.overview" @models={{array run.course.id run.id}} @tagName="button"
class="button-orange button-solid">
{{resumeButtonText}}
</LinkTo>
{{#if showGetCertificate}}
<button class="button-green button-solid">Get Certificate</button>
<button class="button-green button-solid">Get Certificate</button>
{{/if}}
</div>
</div>
13 changes: 6 additions & 7 deletions app/pods/components/my-courses-list/run-row/template.hbs
@@ -1,16 +1,15 @@

<div class="row no-gutters align-items-center mt-4">
<div class="col-md-4 col-6">
<div class="col-lg-4 col-md-6">
<div class="row no-gutters align-items-center">
<div class="col-3">
<img class="mr-5 s-80x80" src={{course.logo}} alt={{course.title}}>
<div>
<img class="s-60x60 br-5" src={{course.logo}} alt={{course.title}}>
</div>
<div class="col-9">
<div class="flex-1 pl-4">
<h5 class="bold">{{course.title}}</h5>
<div class="font-normal mt-2">Mentor: {{instrcutorNames}}</div>
<div>Expires {{moment-from-now (unix run.topRunAttempt.end)}} </div>
</div>
</div>
</div>
{{yield run.topRunAttempt.progressPercent}}
</div>
{{yield run.topRunAttempt.progressPercent}}
</div>
68 changes: 30 additions & 38 deletions app/pods/components/player/player-doubts-tab/template.hbs
@@ -1,46 +1,38 @@
<div class="py-4 d-flex align-items-center font-sm">
<span class="bold">Filter Doubts</span>
<div class="py-4 row no-gutters align-items-center font-sm">
<span class="bold col-sm-2 col-12 mb-sm-0 mb-3">Filter Doubts</span>

<div class="input-radio gradient-input small ml-4">
<input
checked={{eq filter 'all'}}
type="radio"
id="my-doubts"
onclick={{action (mut filter) 'all'}} />
<label for="my-doubts">
<span class="ml-3">
My Doubts
</span>
</label>
</div>
<div class="col-sm-10 col-6 row no-gutters">
<div class="input-radio gradient-input small ml-sm-4">
<input checked={{eq filter 'all'}} type="radio" id="my-doubts" onclick={{action (mut filter) 'all'}} />
<label for="my-doubts">
<span class="ml-3">
My Doubts
</span>
</label>
</div>

<div class="input-radio gradient-input small ml-4">
<input
checked={{eq filter 'resolved'}}
type="radio"
id="resolved-doubts"
onclick={{action (mut filter) 'resolved'}} />
<label for="resolved-doubts">
<span class="ml-3">
Resolved Doubts
</span>
</label>
</div>
<div class="input-radio gradient-input small ml-sm-4 mt-sm-0 mt-2">
<input checked={{eq filter 'resolved'}} type="radio" id="resolved-doubts"
onclick={{action (mut filter) 'resolved'}} />
<label for="resolved-doubts">
<span class="ml-3">
Resolved Doubts
</span>
</label>
</div>

<div class="input-radio gradient-input small ml-4">
<input
checked={{eq filter 'unresolved'}}
type="radio"
id="unresolved-doubts"
onclick={{action (mut filter) 'unresolved'}} />
<label for="unresolved-doubts">
<span class="ml-3">
Unresolved Doubts
</span>
</label>
<div class="input-radio gradient-input small ml-sm-4 mt-sm-0 mt-2">
<input checked={{eq filter 'unresolved'}} type="radio" id="unresolved-doubts"
onclick={{action (mut filter) 'unresolved'}} />
<label for="unresolved-doubts">
<span class="ml-3">
Unresolved Doubts
</span>
</label>
</div>
</div>
</div>

<div class="divider-h"></div>

<Player::PlayerDoubtsList @doubts={{doubtsList}} />
<Player::PlayerDoubtsList @doubts={{doubtsList}} />
2 changes: 1 addition & 1 deletion app/pods/components/player/player-tabs/template.hbs
@@ -1,4 +1,4 @@
<div class="row py-4 no-gutters align-items-center justify-content-between ">
<div class="row py-4 no-gutters align-items-center justify-content-between">
<div class="col-8">
<h3 class="gradient-text-orange bold">
Get 24*7 Doubts &amp; Mentor Support
Expand Down
4 changes: 2 additions & 2 deletions lib/ember-w-pack/addon/templates/components/w-tab-nav.hbs
@@ -1,6 +1,6 @@
<div class="tab-nav-underline w-100 justify-content-start {{tabClass}} ">
<div class="tab-nav-underline w-100 justify-content-start t-align-c {{tabClass}}">
{{#each @tabs as |tab index|}}
<div class="tab px-0 mr-5 font-sm bold {{if (eq tab activeTab) 'active' inactiveClass}}" {{on "click" (action @onTabChange tab)}}>{{tab.name}}</div>
<div class="tab px-0 mr-md-5 mr-sm-4 mr-3 font-sm bold {{if (eq tab activeTab) 'active' inactiveClass}}" {{on "click" (action @onTabChange tab)}}>{{tab.name}}</div>
{{/each}}
</div>
<div>
Expand Down

0 comments on commit 999415c

Please sign in to comment.