Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onchange replaces onClick to solve failed prop type fix #126 #127

Merged
merged 1 commit into from May 27, 2020

Conversation

jugshaurya
Copy link
Contributor

@jugshaurya jugshaurya commented May 26, 2020

Issue

fixes: #126

Solution

onChange prop must be provided if used checked to make it controlled component

Checklist

PR will only be reviewed if the checklist is completed

  • I have done extensive testing for my changes.
  • I have self-reviewed my PR and removed all unnecessary changes.
  • My changes works well on both desktop and mobile environments.
  • I have made sure that my changes solve the actual problem mentioned in the issue.
  • The PR contains only 1 commit and have been updated with master.

@thenamankumar thenamankumar merged commit 928f1fd into coding-blocks:master May 27, 2020
@boss-contributions-bot
Copy link

boss-contributions-bot bot commented May 27, 2020

Congratualtions @jugshaurya, your pull request is merged! 🎉

Thanks for your contributions and participating in BOSS 2020. 🙌

You can claim your bounty points here. 💰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: onChange not found when checked is passed as prop
2 participants