Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

75 Roulette in Java #481

Merged
merged 13 commits into from
Jan 11, 2022
Merged

75 Roulette in Java #481

merged 13 commits into from
Jan 11, 2022

Conversation

LittleTealeaf
Copy link
Contributor

Going to open this pull request, I'm slightly confused with understanding how the money situation works (with the end of the game, etc.)
Wanted to see if what I wrote was fine or if I misinterpreted from the code listed

@coding-horror
Copy link
Owner

coding-horror commented Jan 10, 2022

The best thing to do is test it against the original code, do you have any way of running the original BASIC?

@LittleTealeaf
Copy link
Contributor Author

Not at the moment. I don't have experience actually using BASIC, but I can try to figure it out later. Thanks

@coding-horror
Copy link
Owner

I'm asking on Twitter the best way to verify running these old BASIC progs.

@LittleTealeaf
Copy link
Contributor Author

My go-to has been to try my hand at walking through and understanding the basic code, and look at other language implementations. This one seems a bit more confusing, and probably is going to require me to go in and mark it up a bit on my own to figure out what it's exactly doing.

Slowly going through and making output true to the original BASIC code
@journich
Copy link
Contributor

@LittleTealeaf many people use Vintage Basic to run the basic programs.

Windows, Mac and Linux versions are there. I'm running it on a Mac with no problems.

@LittleTealeaf
Copy link
Contributor Author

@journich Thanks, I'll take a look at that when I get a chance. I'll go back to the programs I've merged previously and try to update those to match the outputs and functionality better, as I believe I got as close as I thought I could, but not exact.

@journich
Copy link
Contributor

@LittleTealeaf I've found it much much easier porting the code in conjunction with running the original basic code. From time to time I even made little changes to the basic code when running it (mostly adding debugging code to print variable values and so on).

@LittleTealeaf
Copy link
Contributor Author

Ok, I changed the output so it more closely mirrors what the original program would say (apart from some small changes, such as adding a space in-between some words that were smushed together).
I think it's currently in a finished state so I will open this up as a pull request

@LittleTealeaf LittleTealeaf marked this pull request as ready for review January 11, 2022 19:17
@LittleTealeaf LittleTealeaf changed the title 75_Roulette in Java 75 Roulette in Java Jan 11, 2022
@LittleTealeaf
Copy link
Contributor Author

I know I made a bunch of changes above, I should be all set, unless someone else notices something wrong in my code

@coding-horror
Copy link
Owner

Excellent thank you!!

@coding-horror coding-horror merged commit dc56c65 into coding-horror:main Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants