Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make games easy accessable on the web #631

Merged
merged 3 commits into from
Mar 18, 2022

Conversation

mojoaxel
Copy link
Collaborator

@mojoaxel mojoaxel commented Mar 12, 2022

  • This PR creates a index.html in the root of the repository.
  • With this it gets easy to access the games directly in the browser without downloading the repository.
  • There is also a new script 00_Utilities/build-index.js, that creates the index.html for the given folder structure.
  • After merging this github-pages can easily be enabled for this repository. (see also [Idea] Publish to GitHub pages #577)
    If we don't want these files in the main branch, feel free to merge than into a seperate branch (e.g. gh-pages) and only enable github-pages for this branch.)

Here is an example: https://mojoaxel.github.io/basic-computer-games/
image

Open ToDos:

What do you think? Any ideas for improvements?

@DLotts
Copy link

DLotts commented Mar 13, 2022

OMG, this is awesome! I was able to check the behavior of my version of Nim against the JavaScript version. It turns the whole book into a playable website! I feel so old fashioned with my files and my executables. :-)

@coding-horror
Copy link
Owner

ok! Let me know when it is ready. Also contact me if you want to help own the repository, I could use some co-owner help! 🙏

@mojoaxel mojoaxel force-pushed the gh-pages branch 2 times, most recently from cdd5b3a to 6bb9a62 Compare March 17, 2022 07:34
@mojoaxel mojoaxel marked this pull request as ready for review March 17, 2022 07:39
@mojoaxel
Copy link
Collaborator Author

mojoaxel commented Mar 17, 2022

@coding-horror I think this is ready to be merged

  • The failing python pipeline has nothing to do with my changes. See Python: Code cleanup #647
  • A github action to auto-regenerate the index.html is still missing, but this could easily be added later.
  • I would recommend simply merging this into main and than enable github-pages for the main branch. This way everything stays easy and manageable (This is still targeted for beginners!).
  • I would feel honored to become a maintainer for this repository, but I'm not promising anything 😉

@coding-horror coding-horror merged commit 0dcb201 into coding-horror:main Mar 18, 2022
@coding-horror
Copy link
Owner

Ok I enabled github pages for the main branch, does it look OK to you?

@mojoaxel
Copy link
Collaborator Author

@mojoaxel
Copy link
Collaborator Author

@coding-horror Could you please add the url as the Website to the repository details.
Also feel free to add me as a maintainer, I'll try to help out with issues and review merge requests.

@coding-horror
Copy link
Owner

Excellent I have added you as a collaborator! Let's see where this goes, I can use the help and deeply appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants