Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rust implementation of 55_Life #820

Merged
merged 8 commits into from
Oct 12, 2022

Conversation

jonfetterdegges
Copy link
Contributor

No description provided.

Merged the functionality of update_bounds into finish_cell_transitions,
eliminating a loop.
get_pattern now checks the size of the input to prevent out of bounds
writes., and converts String to Vec<char> immediately.

Refactors: changed function names, ran rust-fmt, improved some comments
Implemented Display for CellState, and tweaked outputs to match the
BASIC implementation.

Also fixed some more comments.
Copy link
Contributor

@AnthonyMichaelTDM AnthonyMichaelTDM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, great use of comments!

not so sure how I feel about the 500ms delay, but that shouldn't really be a problem.

@coding-horror coding-horror merged commit 3fd58e4 into coding-horror:main Oct 12, 2022
rjrw pushed a commit to rjrw/basic-computer-games that referenced this pull request Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants