🐛 fix a bug in webpack config 🔧 change external cdn source to cdn.boo…

…tcss.com
coding · Apr 5, 2017 · cef7665 · cef7665
1 parent af0d154
commit cef7665
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/app/index.html b/app/index.html
@@ -8,10 +8,8 @@
   <meta name="Description" content="Coding WebIDE 是Coding自主研发的在线集成开发环境。用户可以通过WebIDE创建项目的工作空间，进行在线开发，调试等操作。与此同时，WebIDE
     还提供了可分享的开发环境功能，用户可以保存当前的 Terminal 环境，分享给团队的其他成员。">
   <link rel="icon" type="image/x-icon" href="favicon.ico">
-  <!--<link rel="stylesheet" href="/node_modules/codemirror/lib/codemirror.css">-->
-  <!--<link rel="stylesheet" href="/node_modules/codemirror/theme/monokai.css">-->
-  <script src="https://use.fontawesome.com/838df4727b.js"></script>
-  <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/octicons/4.4.0/font/octicons.css">
+  <link rel="stylesheet" href="//cdn.bootcss.com/font-awesome/4.7.0/css/font-awesome.min.css">
+  <link rel="stylesheet" href="//cdn.bootcss.com/octicons/4.4.0/font/octicons.min.css">
 </head>
 <body>
   <div id="root">

diff --git a/webpack_configs/common.config.js b/webpack_configs/common.config.js
@@ -14,16 +14,14 @@ module.exports = function (options={}) {
     staticDir = 'rs',
   } = options
 
-let publicPath = path.join('/', staticDir)
-if (!publicPath.endsWith('/')) publicPath + '/'
 return {
   entry: {
     main: [path.join(rootDir, 'app')],
     workspaces: [path.join(rootDir, 'app/workspaces_standalone')],
     vendor: ['babel-polyfill', 'react', 'react-dom', 'redux', 'react-redux'],
   },
   output: {
-    publicPath,
+    publicPath: path.join('/', staticDir, '/'), // publicPath should end with '/'
     path: path.join(rootDir, 'build', staticDir),
     filename: '[name].[hash].js'
   },