Make hints optional #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made the use of hints optional, given that, for some rules, the title is descriptive enough.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 148 149 +1
=========================================
+ Hits 148 149 +1
☔ View full report in Codecov by Sentry. |
codingjoe
force-pushed
the
El-Virus-optional-hints
branch
from
6978053
to
b754703
Compare
codingjoe
reviewed
May 24, 2023
There was a problem hiding this comment.
Hi @El-Virus,
Thank you for your contribution. I always appreciate the help and people involvement in my passion projects.
I left you a couple of comments to further improve your contribution. I also took the liberty and added a test, as writing a test in an unfamiliar setup can be hard for first-time contributors to a new project.
Cheers!
Joe
codingjoe
force-pushed
the
El-Virus-optional-hints
branch
from
b754703
to
b00dc82
Compare
|
Note: I've 0 experience with codecov & have no idea why it's failing its tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the use of hints optional, given that, for some rules, the title is descriptive enough.