Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rate limiting feature #34

Closed
timkent opened this issue Sep 28, 2017 · 8 comments
Closed

Add rate limiting feature #34

timkent opened this issue Sep 28, 2017 · 8 comments

Comments

@timkent
Copy link
Collaborator

timkent commented Sep 28, 2017

Currently VHostScan will fire off requests as fast as possible, this is probably not ideal for all situations.

Rate limiting or a configurable pause between requests would be a good feature to add.

@cryguy
Copy link

cryguy commented Sep 28, 2017

can we use external library's for it? or do we not want any external libs?

@codingo
Copy link
Owner

codingo commented Sep 28, 2017

@cryguy Depends on the library - any suggestions? I think it could be done a natively but I'm open to a library if it leads to a better end result.

@cryguy
Copy link

cryguy commented Sep 28, 2017

am looking at - https://pypi.python.org/pypi/ratelimit right now

edit - doing it natively will be easier i guess

@timkent
Copy link
Collaborator Author

timkent commented Sep 28, 2017

Thanks @cryguy for looking at this!

If you do use an external library, try to preference ones that are packaged in Debian if possible, as we want to try to package this up eventually to make it really simple to install in Kali.

Obviously don't discount others if they are a better fit, but please factor this in.

@grimd34th
Copy link
Contributor

#40
Added a time.sleep to the function call with a default of 0, uses python standard libraries so no additional deps

@cryguy
Copy link

cryguy commented Sep 28, 2017

#39 added ratelimit and documentation for ratelimit func

@codingo
Copy link
Owner

codingo commented Sep 28, 2017

@cryguy @grimd34th Happy for open discussion on which approach you feel is better (#39, #40). I don't believe there's too many edge cases here that either wouldn't solve but I'm happy to be proven wrong!

@codingo
Copy link
Owner

codingo commented Oct 2, 2017

Closed with #40, #44

@codingo codingo closed this as completed Oct 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants