Geocoder as an interface to allow for chained and cached types #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10
Make the top-level
Geocoder
type an interface and the HTTP specific one aHTTPGeocoder
This will be useful for implementing more abstract Geocoder types like Chained fallback ones or cached ones as described here #10
Also made
ResponseObject()
be a function that returns new instances (I think there may have been a concurrency issue because the Geocoders were returning the same pointer for every call, so if you made concurrent calls to a Geocoder API it would be decoding to the same response pointer).