Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: readOnly mode support #13

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

hrsy
Copy link

@hrsy hrsy commented Aug 3, 2021

@shafua
Copy link

shafua commented Aug 3, 2021

@arwazjamal please, check introduction of readonly mode by @VanishMax ( #5 ) and fix of implementation by passing of readOnly variable to TableConstructor in _createTableConfiguration method.
Also, here we changed the arguments type of TableConstructor to named ones.

@VanishMax
Copy link

VanishMax commented Aug 18, 2021

@hrsy @shafua Hey! I've added your commits to the initial PR #5, cause I needed the table block once again. We have two equal PRs now 😅
And thanks for update!

@jaspergrannetia
Copy link

Hi,

I am quite new to EditorJS and was looking for a table tool that supports readonly mode. I look like this Feature is just the thing I am looking for. I am not fully up to speed on GitHub procedures, but it looks like this Feature is waiting for merging into the master, right. The master certainly does not support readonly yet.

Who may I graciously ask to help include the readonly mode into the master? Anything I can do to help?

Thnx!

Jasper

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants