accounts with short delete_every but restrictive filters cause lots of refreshes

[codl]

ive had the occasional complaint that forget was making a lot of requests and i couldnt say why but now i know

in delete_from_account, this query:

forget/tasks.py

Lines 231 to 238 in 41683fc

	latest_n_posts = (Post.query.with_parent(account, 'posts').order_by(
	db.desc(Post.created_at)).limit(account.policy_keep_latest)
	.cte(name='latest'))
	posts = (
	Post.query.with_parent(account, 'posts')
	.filter(Post.created_at + account.policy_keep_younger <= db.func.now())
	.filter(~Post.id.in_(db.select((latest_n_posts.c.id, )))).order_by(
	db.func.random()).limit(100).all())

does not use any of the filters, and every post that is returned from it is refreshed until one of them matches all the filters

if someone has restrictive filters like "delete media only" or "delete faves only" then this will likely get 100 posts that don't match, do 100 requests to refresh them, and fail to delete anything

[codl]

i really really wish mastodon had an endpoint for getting a lot of posts by id like twitter does

cough mastodon/mastodon#6136