feat(fastify#284): update multipart package min required version that…

… introduced breaking change and implement CR
codrin-ch · Jan 28, 2023 · d68df13 · d68df13
1 parent 0bf4a4a
commit d68df13
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 6 deletions.
diff --git a/README.md b/README.md
@@ -241,7 +241,8 @@ fastify.register(FastifyReplyFrom, {
   base: 'http://localhost:3001/',
   // http and https is allowed to use http.globalAgent or https.globalAgent
   globalAgent: true, 
-  undici: false
+  http: {
+  }
 })
 ```
 

diff --git a/index.js b/index.js
@@ -241,7 +241,7 @@ function onErrorDefault (reply, { error }) {
 }
 
 function isFastifyMultipartRegistered (fastify) {
-  return fastify.hasContentTypeParser('multipart') && fastify.hasRequestDecorator('multipart')
+  return fastify.hasContentTypeParser('multipart/form-data') && fastify.hasRequestDecorator('multipart')
 }
 
 function createRequestRetry (requestImpl, reply, retriesCount, retryOnError, maxRetriesOn503) {

diff --git a/package.json b/package.json
@@ -28,8 +28,8 @@
   },
   "homepage": "https://github.com/fastify/fastify-reply-from#readme",
   "devDependencies": {
-    "@fastify/formbody": "^7.0.1",
-    "@fastify/multipart": "^7.1.0",
+    "@fastify/formbody": "^7.4.0",
+    "@fastify/multipart": "^7.4.0",
     "@fastify/pre-commit": "^2.0.2",
     "@sinonjs/fake-timers": "^10.0.0",
     "@types/node": "^18.0.0",

diff --git a/test/http-global-agent.js b/test/http-global-agent.js
@@ -33,7 +33,8 @@ target.listen({ port: 0 }, (err) => {
   instance.register(From, {
     base: `http://localhost:${target.address().port}`,
     globalAgent: true,
-    undici: false
+    http: {
+    }
   })
 
   instance.listen({ port: 0 }, (err) => {

diff --git a/test/https-global-agent.js b/test/https-global-agent.js
@@ -42,7 +42,8 @@ target.listen({ port: 0 }, (err) => {
   instance.register(From, {
     base: `https://localhost:${target.address().port}`,
     globalAgent: true,
-    undici: false
+    http: {
+    }
   })
 
   instance.listen({ port: 0 }, (err) => {