Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the proxies in requests download #46

Conversation

grammy-jiang
Copy link
Contributor

@grammy-jiang grammy-jiang commented Apr 8, 2024

This pull request enables to download with the environment variables of HTTP_PROXY, HTTPS_PROXY, http_proxy and https_proxy.

Refer to:

@grammy-jiang
Copy link
Contributor Author

This pull request is quite similar with #44 - introduce the environment variables to the compiling process. In the future these environment variables introduce will be probably moved to a configurable feature.

Copy link

@zsimic zsimic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not familiar with using proxies, but this LGTM

@zsimic zsimic merged commit d01d8ce into codrsquad:main Apr 9, 2024
8 checks passed
@grammy-jiang grammy-jiang deleted the feature/MAST-9416-allow-proxy-in-downloading branch April 9, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants