Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled more lint rules, notably flake8-pytest #31

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Conversation

zsimic
Copy link
Collaborator

@zsimic zsimic commented Mar 5, 2024

Enabled:

  • PT flake8-pytest
  • PYI flake8-pyi
  • Q flake8-quotes
  • RSE flake8-raise
  • RUF ruff-specific
  • SLOT flake8-slots
  • T10 flake8-debugger
  • TID flake8-tidy-imports
  • TCH flake8-type-checking
  • TD flake8-todos
  • W pycodestyle warnings

Copy link
Contributor

@thatch thatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the pytest.raises(..., match=...) changes, but this is hard to review otherwise. Were these all generated fixes by the linter, even changing exception types and argument names? Those aren't immediately obvious to be backwards-compatible.

@zsimic
Copy link
Collaborator Author

zsimic commented Mar 5, 2024

ruff-specific suggested the exception change, didn't try letting it automatically apply fix (did it manually). The backwards incompatible changes are not used, I checked. The suggestion to use TypeError makes sense.

@zsimic zsimic merged commit b4f1d78 into main Mar 5, 2024
8 checks passed
@zsimic zsimic deleted the more-linter-rules branch March 5, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants