fix: tend a falsy opts.cb

packages/string-fix-broken-named-entities/coverage/coverage-summary.json

@@ -1 +1 @@
-{"total":{"lines":{"total":219,"covered":219,"skipped":0,"pct":100},"statements":{"total":233,"covered":233,"skipped":0,"pct":100},"functions":{"total":26,"covered":26,"skipped":0,"pct":100},"branches":{"total":308,"covered":308,"skipped":0,"pct":100}}}
+{"total":{"lines":{"total":218,"covered":218,"skipped":0,"pct":100},"statements":{"total":234,"covered":234,"skipped":0,"pct":100},"functions":{"total":26,"covered":26,"skipped":0,"pct":100},"branches":{"total":309,"covered":309,"skipped":0,"pct":100}}}

packages/string-fix-broken-named-entities/dist/string-fix-broken-named-entities.cjs.js

@@ -551,7 +551,12 @@ function fixEnt(str, originalOpts) {
     return rangesArr2.every(function (oneOfEveryObj, y) {
       return i === y || !(filteredRangeObj.rangeFrom >= oneOfEveryObj.rangeFrom && filteredRangeObj.rangeTo < oneOfEveryObj.rangeTo);
     });
-  }).map(opts.cb);
+  });
+  /* istanbul ignore else */
+  if (typeof opts.cb === "function") {
+    return res.map(opts.cb);
+  }
+  /* istanbul ignore next */
   return res;
 }
 

packages/string-fix-broken-named-entities/dist/string-fix-broken-named-entities.dev.umd.js

@@ -10719,7 +10719,14 @@ function fixEnt(str, originalOpts) { //
     return rangesArr2.every(function (oneOfEveryObj, y) {
       return i === y || !(filteredRangeObj.rangeFrom >= oneOfEveryObj.rangeFrom && filteredRangeObj.rangeTo < oneOfEveryObj.rangeTo);
     });
-  }).map(opts.cb);
+  });
+  /* istanbul ignore else */
+
+  if (typeof opts.cb === "function") {
+    return res.map(opts.cb);
+  }
+  /* istanbul ignore next */
+
   return res;
 }
 

packages/string-fix-broken-named-entities/dist/string-fix-broken-named-entities.esm.js

@@ -514,11 +514,12 @@ function fixEnt(str, originalOpts) {
   if (!rangesArr2.length) {
     return [];
   }
-  const res = rangesArr2.filter((filteredRangeObj, i) => {
-    return rangesArr2.every((oneOfEveryObj, y) => {
-      return i === y || !(filteredRangeObj.rangeFrom >= oneOfEveryObj.rangeFrom && filteredRangeObj.rangeTo < oneOfEveryObj.rangeTo);
-    });
-  }).map(opts.cb);
+  const res = rangesArr2.filter((filteredRangeObj, i) => rangesArr2.every((oneOfEveryObj, y) => i === y || !(filteredRangeObj.rangeFrom >= oneOfEveryObj.rangeFrom && filteredRangeObj.rangeTo < oneOfEveryObj.rangeTo)));
+  /* istanbul ignore else */
+  if (typeof opts.cb === "function") {
+    return res.map(opts.cb);
+  }
+  /* istanbul ignore next */
   return res;
 }
 

packages/string-fix-broken-named-entities/src/main.ts

@@ -35,7 +35,7 @@ interface cbObj {
 }
 interface Opts {
   decode: boolean;
-  cb: (obj: cbObj) => void;
+  cb: null | ((obj: cbObj) => void);
   entityCatcherCb: null | ((from: number, to: number) => void);
   textAmpersandCatcherCb: null | ((idx: number) => void);
   progressFn: null | ((percDone: number) => void);
@@ -1506,27 +1506,31 @@ function fixEnt(str: string, originalOpts?: Partial<Opts>): Ranges {
   //     "rangeValDecoded": "&"
   // },
   // so instead of [4, 8] that would be [rangeFrom, rangeTo]...
-  const res: any = rangesArr2
-    .filter((filteredRangeObj, i) => {
-      return rangesArr2.every((oneOfEveryObj, y) => {
-        return (
-          i === y ||
-          !(
-            filteredRangeObj.rangeFrom >= oneOfEveryObj.rangeFrom &&
-            filteredRangeObj.rangeTo < oneOfEveryObj.rangeTo
-          )
-        );
-      });
-    })
-    .map(opts.cb);
+  const res: any = rangesArr2.filter((filteredRangeObj, i) =>
+    rangesArr2.every(
+      (oneOfEveryObj, y) =>
+        i === y ||
+        !(
+          filteredRangeObj.rangeFrom >= oneOfEveryObj.rangeFrom &&
+          filteredRangeObj.rangeTo < oneOfEveryObj.rangeTo
+        )
+    )
+  );
+
+  /* istanbul ignore else */
+  if (typeof opts.cb === "function") {
+    console.log(`1522 ${`\u001b[${32}m${`RETURN`}\u001b[${39}m`} mapped`);
+    return res.map(opts.cb);
+  }
 
   console.log(
-    `1524 RETURN ${`\u001b[${33}m${`res`}\u001b[${39}m`} = ${JSON.stringify(
+    `1527 RETURN ${`\u001b[${33}m${`res`}\u001b[${39}m`} = ${JSON.stringify(
       res,
       null,
       4
     )}`
   );
+  /* istanbul ignore next */
   return res;
 }
 

packages/string-fix-broken-named-entities/test/throws.js

@@ -91,3 +91,27 @@ tap.test(
     t.end();
   }
 );
+
+tap.test(`07 - all callbacks are undefined`, (t) => {
+  t.doesNotThrow(() => {
+    fix("", {
+      cb: undefined,
+      entityCatcherCb: undefined,
+      textAmpersandCatcherCb: undefined,
+      progressFn: undefined,
+    });
+  }, "07");
+  t.end();
+});
+
+tap.test(`08 - all callbacks are nulls`, (t) => {
+  t.doesNotThrow(() => {
+    fix("", {
+      cb: null,
+      entityCatcherCb: null,
+      textAmpersandCatcherCb: null,
+      progressFn: null,
+    });
+  }, "08");
+  t.end();
+});

packages/string-fix-broken-named-entities/types/index.d.ts

@@ -13,7 +13,7 @@ interface cbObj {
 }
 interface Opts {
     decode: boolean;
-    cb: (obj: cbObj) => void;
+    cb: null | ((obj: cbObj) => void);
     entityCatcherCb: null | ((from: number, to: number) => void);
     textAmpersandCatcherCb: null | ((idx: number) => void);
     progressFn: null | ((percDone: number) => void);