Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update how we generate excerpts #114

Closed
wants to merge 3 commits into from

Conversation

EvanBurbidge
Copy link
Contributor

✨ Codu Pull Request πŸ’»

Codu Logo

πŸ‘‰ Please remove the below and replace with your own values, leaving the headers where they are. πŸ‘ˆ

Pull Request details:

  • This pull request resolves Only generate excerpt if post is published without excerptΒ #111
  • Originally the excerpt was being generated on each update of the draft, if it didn't exist it was taking the first 156 chars of the body and generating one.
  • The new behaviour puts this into the publish method only generating one if required on publish.

Any Breaking changes:

  • IF ANYTHING YOU'RE COMMITTING WOULD BREAK SOMETHING, INCLUDE HERE WHAT WOULD BREAK
  • IF YOU HAVE NO BREAKING CHANGES, ENTER 'None'

Associated Screenshots:

( Welcome file extensions include gifs/png screenshots of your feature in action )

  • IF YOU HAVE ANY SCREENSHOTS, INCLUDE THEM HERE.
  • IF YOU HAVE NO SCREENSHOTS, ENTER 'None'

@vercel
Copy link

vercel bot commented Nov 28, 2022

@EvanBurbidge is attempting to deploy a commit to the CodΓΊ Team on Vercel.

A member of the Team first needs to authorize it.

@EvanBurbidge EvanBurbidge changed the title update how we generate excerpts WIP: update how we generate excerpts Nov 28, 2022
NiallJoeMaher
NiallJoeMaher previously approved these changes Nov 29, 2022
Copy link
Contributor

@NiallJoeMaher NiallJoeMaher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vercel
Copy link

vercel bot commented Nov 29, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
codu βœ… Ready (Inspect) Visit Preview Nov 30, 2022 at 10:18PM (UTC)

@NiallJoeMaher
Copy link
Contributor

Is this ready to review? I still see WIP

@EvanBurbidge EvanBurbidge changed the title WIP: update how we generate excerpts Update how we generate excerpts Dec 12, 2022
Copy link
Contributor

@NiallJoeMaher NiallJoeMaher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be a lot of changes in the order of classes? Is there a reason this happened or should they be removed?

@NiallJoeMaher
Copy link
Contributor

@EvanBurbidge closing this since it's gone a bit stale, and my latest PR should resolve this.
Thanks for the help brother. <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only generate excerpt if post is published without excerpt
2 participants