Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix always open menu on article sidebar after selection #594

Closed
NiallJoeMaher opened this issue Oct 24, 2023 · 7 comments 路 Fixed by #615
Closed

Fix always open menu on article sidebar after selection #594

NiallJoeMaher opened this issue Oct 24, 2023 · 7 comments 路 Fixed by #615
Assignees

Comments

@NiallJoeMaher
Copy link
Contributor

Context

After selecting a option on the sidebar menu or cllicking away the menu should close.

Here's an example of it staying open when you open the report modal:

Screenshot 2023-10-24 at 11 31 53

Make sure this behavior is the same on mobile too! 馃

Expected Behavior

The menu should close after you choose and option or click away from the menu.

Steps to reproduce

  1. Go to any article
  2. Select the menu on the left
  3. Select "Report article" to view the modal
@RajuGangitla
Copy link
Contributor

@NiallJoeMaher can I work on this issue

@NiallJoeMaher
Copy link
Contributor Author

Absolutely @RajuGangitla

@seog-jun
Copy link
Contributor

If there's no one working on it, can I have a look?

@AnuMessi10
Copy link
Contributor

Hey @NiallJoeMaher it's me again, I have already implemented this functionality for production grade web apps, let me know if you can assign this to me. Cheers! 馃槃

@NiallJoeMaher
Copy link
Contributor Author

If there's no one working on it, can I have a look?

It's all yours if you want! Let me know if you don't want it anymore so I can assign to @AnuMessi10

@seog-jun
Copy link
Contributor

Then let me give it a shot and if I'm not figuring it out, I'll give it to @AnuMessi10 and you can create PR. Give me some time to do that thanks!

@seog-jun
Copy link
Contributor

seog-jun commented Nov 5, 2023

Status update: there was progress in closing Popover Panel when clicking Report Article but Modal disappears right away as Popover Panel is closed. Still figuring out how to close Popover only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants