Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add break-words class to excerpt paragraph #69

Merged
merged 1 commit into from Oct 18, 2022
Merged

Add break-words class to excerpt paragraph #69

merged 1 commit into from Oct 18, 2022

Conversation

gdomaradzki
Copy link
Contributor

@gdomaradzki gdomaradzki commented Oct 15, 2022 •
edited

✨ Codu Pull Request 💻

Codu Logo

Pull Request details:

  • Add break-words class to excerpt's p tag
  • Resolves Article body is overflowing #67
  • There's also an issue with eslint in the same file because we are using an img tag instead of next's Image component. Should we ignore this eslint rule for this file?

Any Breaking changes:

  • None

Associated Screenshots:

image

@vercel
Copy link

vercel bot commented Oct 15, 2022

@gdomaradzki is attempting to deploy a commit to the Codú Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Oct 15, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
codu ✅ Ready (Inspect) Visit Preview Oct 15, 2022 at 0:07AM (UTC)

@pkspyder007
Copy link
Collaborator

Thanks for contributing @gdomaradzki

@NiallJoeMaher we can merge this one.

NiallJoeMaher
NiallJoeMaher approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@NiallJoeMaher NiallJoeMaher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@NiallJoeMaher NiallJoeMaher merged commit 82e1d25 into codu-code:develop Oct 18, 2022
@NiallJoeMaher NiallJoeMaher mentioned this pull request Jul 19, 2023
Closed
NiallJoeMaher pushed a commit that referenced this pull request Oct 6, 2023
@gdomaradzki
Add break-words class to excerpt paragraph (#69)
465d24b
@gdomaradzki gdomaradzki deleted the fix/article-excerpt-overflowing branch February 18, 2024 07:11
@gdomaradzki gdomaradzki restored the fix/article-excerpt-overflowing branch February 18, 2024 07:12
@gdomaradzki gdomaradzki deleted the fix/article-excerpt-overflowing branch February 18, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiallJoeMaher NiallJoeMaher NiallJoeMaher approved these changes

@pkspyder007 pkspyder007 Awaiting requested review from pkspyder007

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Article body is overflowing
3 participants
@gdomaradzki @pkspyder007 @NiallJoeMaher