Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed padding issues with the author information. #89

Closed
wants to merge 1 commit into from

Conversation

VSB14
Copy link
Contributor

@VSB14 VSB14 commented Oct 28, 2022

✨ Codu Pull Request 💻

Codu Logo

Pull Request details:

  • The Padding attributes "px-4" have been removed from Biobar.tsx file to fix the alignment issues with the author information at the end of each article.

Any Breaking changes:

  • None

Associated Screenshots:

Before Commit

image

After Commit

image

@vercel
Copy link

vercel bot commented Oct 28, 2022

@VSB14 is attempting to deploy a commit to the Codú Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@auxfuse auxfuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change here! Just one thing for feedback considerations 🤜

@@ -15,8 +15,8 @@ const BioFooter = ({ author }: Props) => {

const { name, image, bio, username } = author;
return (
<div className="max-w-xl px-4 mx-auto text-gray-700 dark:text-gray-300 mt-6">
<div className="flex mx-2 sm:mx-6 md:mx-auto px-4 border-t-2 pt-6 border-gray-300 dark:border-gray-800">
<div className="max-w-xl mx-auto text-gray-700 dark:text-gray-300 mt-6">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we consider removing the double-space present in this line between mx-auto & text-gray-700 ? 🤔 It's not a big deal that won't break anything, but it is a nice standard to adhere to 😅

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Eagle eyes 🦅

@vercel
Copy link

vercel bot commented Oct 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
codu ✅ Ready (Inspect) Visit Preview Oct 28, 2022 at 0:13AM (UTC)

@pkspyder007
Copy link
Collaborator

@auxfuse I think we should add linting config and git hooks to automate these small issues.
can you open some issues for the same, It would be some nice beginners issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants