New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed padding issues with the author information. #89
Conversation
@VSB14 is attempting to deploy a commit to the Codú Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice change here! Just one thing for feedback considerations 🤜
@@ -15,8 +15,8 @@ const BioFooter = ({ author }: Props) => { | |||
|
|||
const { name, image, bio, username } = author; | |||
return ( | |||
<div className="max-w-xl px-4 mx-auto text-gray-700 dark:text-gray-300 mt-6"> | |||
<div className="flex mx-2 sm:mx-6 md:mx-auto px-4 border-t-2 pt-6 border-gray-300 dark:border-gray-800"> | |||
<div className="max-w-xl mx-auto text-gray-700 dark:text-gray-300 mt-6"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we consider removing the double-space present in this line between mx-auto
& text-gray-700
? 🤔 It's not a big deal that won't break anything, but it is a nice standard to adhere to 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! Eagle eyes 🦅
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@auxfuse I think we should add linting config and git hooks to automate these small issues. |
✨ Codu Pull Request 💻
Pull Request details:
Any Breaking changes:
Associated Screenshots: