Closed other extension points by adding final to all classes

coduo · Dec 13, 2015 · f093f86 · f093f86
1 parent a5aa961
commit f093f86
Show file tree

Hide file tree

Showing 30 changed files with 60 additions and 53 deletions.
diff --git a/spec/Coduo/PHPHumanizer/DateTime/FormatterSpec.php b/spec/Coduo/PHPHumanizer/DateTime/FormatterSpec.php
@@ -30,19 +30,23 @@ function let(Translator $translator)
         )->willReturn('10 minut temu');
     }
 
-    function it_format_datetime_diff(Difference $diff)
+    function it_format_datetime_diff()
     {
-        $diff->getUnit()->willReturn(new Minute());
-        $diff->getQuantity()->willReturn(10);
-        $diff->isPast()->willReturn(true);
+        $diff = new Difference(
+            new \DateTime("2015-01-01 00:10:00"),
+            new \DateTime("2015-01-01 00:00:00")
+        );
+
         $this->formatDifference($diff)->shouldReturn('10 minutes ago');
     }
 
-    function it_format_datetime_diff_for_specific_locale(Difference $diff)
+    function it_format_datetime_diff_for_specific_locale()
     {
-        $diff->getUnit()->willReturn(new Minute());
-        $diff->getQuantity()->willReturn(10);
-        $diff->isPast()->willReturn(true);
+        $diff = new Difference(
+            new \DateTime("2015-01-01 00:10:00"),
+            new \DateTime("2015-01-01 00:00:00")
+        );
+
         $this->formatDifference($diff, 'pl')->shouldReturn('10 minut temu');
     }
 }
diff --git a/spec/Coduo/PHPHumanizer/DateTime/PreciseFormatterSpec.php b/spec/Coduo/PHPHumanizer/DateTime/PreciseFormatterSpec.php
@@ -62,29 +62,23 @@ function let(Translator $translator)
         )->willReturn('через 10 дней, 5 часов');
     }
 
-    function it_format_compound_datetime_diff(PreciseDifference $diff, CompoundResult $dayResult,
-        CompoundResult $hourResult)
+    function it_format_compound_datetime_diff()
     {
-        $dayResult->getUnit()->willReturn(new Day());
-        $dayResult->getQuantity()->willReturn(10);
-        $hourResult->getUnit()->willReturn(new Hour());
-        $hourResult->getQuantity()->willReturn(5);
+        $diff = new PreciseDifference(
+            new \DateTime("2015-01-01 00:00:00"),
+            new \DateTime("2015-01-11 05:00:00")   
+        );
 
-        $diff->getCompoundResults()->willReturn(array($dayResult, $hourResult));
-        $diff->isPast()->willReturn(false);
         $this->formatDifference($diff)->shouldReturn('10 days, 5 hours from now');
     }
 
-    function it_format_compound_datetime_diff_for_specific_locale(PreciseDifference $diff,
-        CompoundResult $dayResult, CompoundResult $hourResult)
+    function it_format_compound_datetime_diff_for_specific_locale()
     {
-        $dayResult->getUnit()->willReturn(new Day());
-        $dayResult->getQuantity()->willReturn(10);
-        $hourResult->getUnit()->willReturn(new Hour());
-        $hourResult->getQuantity()->willReturn(5);
-
-        $diff->getCompoundResults()->willReturn(array($dayResult, $hourResult));
-        $diff->isPast()->willReturn(false);
+        $diff = new PreciseDifference(
+            new \DateTime("2015-01-01 00:00:00"),
+            new \DateTime("2015-01-11 05:00:00")
+        );
+
         $this->formatDifference($diff, 'ru')->shouldReturn('через 10 дней, 5 часов');
     }
 }
diff --git a/src/Coduo/PHPHumanizer/Collection/Formatter.php b/src/Coduo/PHPHumanizer/Collection/Formatter.php
@@ -4,7 +4,7 @@
 
 use Symfony\Component\Translation\TranslatorInterface;
 
-class Formatter
+final class Formatter
 {
     /**
      * @var \Symfony\Component\Translation\TranslatorInterface

diff --git a/src/Coduo/PHPHumanizer/Collection/Oxford.php b/src/Coduo/PHPHumanizer/Collection/Oxford.php
@@ -2,7 +2,7 @@
 
 namespace Coduo\PHPHumanizer\Collection;
 
-class Oxford
+final class Oxford
 {
     /**
      * @var Formatter

diff --git a/src/Coduo/PHPHumanizer/DateTime/Difference.php b/src/Coduo/PHPHumanizer/DateTime/Difference.php
@@ -11,7 +11,7 @@
 use Coduo\PHPHumanizer\DateTime\Unit\Week;
 use Coduo\PHPHumanizer\DateTime\Unit\Year;
 
-class Difference
+final class Difference
 {
     /**
      * @var \DateTime

diff --git a/src/Coduo/PHPHumanizer/DateTime/Difference/CompoundResult.php b/src/Coduo/PHPHumanizer/DateTime/Difference/CompoundResult.php
@@ -4,7 +4,7 @@
 
 use Coduo\PHPHumanizer\DateTime\Unit;
 
-class CompoundResult
+final class CompoundResult
 {
     /**
      * @var \Coduo\PHPHumanizer\DateTime\Unit

diff --git a/src/Coduo/PHPHumanizer/DateTime/Formatter.php b/src/Coduo/PHPHumanizer/DateTime/Formatter.php
@@ -4,7 +4,7 @@
 
 use Symfony\Component\Translation\TranslatorInterface;
 
-class Formatter
+final class Formatter
 {
     /**
      * @var \Symfony\Component\Translation\TranslatorInterface

diff --git a/src/Coduo/PHPHumanizer/DateTime/PreciseDifference.php b/src/Coduo/PHPHumanizer/DateTime/PreciseDifference.php
@@ -10,7 +10,7 @@
 use Coduo\PHPHumanizer\DateTime\Unit\Year;
 use Coduo\PHPHumanizer\DateTime\Difference\CompoundResult;
 
-class PreciseDifference
+final class PreciseDifference
 {
     /**
      * @var \DateTime

diff --git a/src/Coduo/PHPHumanizer/DateTime/PreciseFormatter.php b/src/Coduo/PHPHumanizer/DateTime/PreciseFormatter.php
@@ -4,7 +4,7 @@
 
 use Symfony\Component\Translation\TranslatorInterface;
 
-class PreciseFormatter
+final class PreciseFormatter
 {
     /**
      * @var \Symfony\Component\Translation\TranslatorInterface

diff --git a/src/Coduo/PHPHumanizer/DateTime/Unit/Day.php b/src/Coduo/PHPHumanizer/DateTime/Unit/Day.php
@@ -4,7 +4,7 @@
 
 use Coduo\PHPHumanizer\DateTime\Unit;
 
-class Day implements Unit
+final class Day implements Unit
 {
     /**
      * @return string

diff --git a/src/Coduo/PHPHumanizer/DateTime/Unit/Hour.php b/src/Coduo/PHPHumanizer/DateTime/Unit/Hour.php
@@ -4,7 +4,7 @@
 
 use Coduo\PHPHumanizer\DateTime\Unit;
 
-class Hour implements Unit
+final class Hour implements Unit
 {
     /**
      * @return string

diff --git a/src/Coduo/PHPHumanizer/DateTime/Unit/JustNow.php b/src/Coduo/PHPHumanizer/DateTime/Unit/JustNow.php
@@ -4,7 +4,7 @@
 
 use Coduo\PHPHumanizer\DateTime\Unit;
 
-class JustNow implements Unit
+final class JustNow implements Unit
 {
     /**
      * @return string

diff --git a/src/Coduo/PHPHumanizer/DateTime/Unit/Minute.php b/src/Coduo/PHPHumanizer/DateTime/Unit/Minute.php
@@ -4,7 +4,7 @@
 
 use Coduo\PHPHumanizer\DateTime\Unit;
 
-class Minute implements Unit
+final class Minute implements Unit
 {
     /**
      * @return string

diff --git a/src/Coduo/PHPHumanizer/DateTime/Unit/Month.php b/src/Coduo/PHPHumanizer/DateTime/Unit/Month.php
@@ -4,7 +4,7 @@
 
 use Coduo\PHPHumanizer\DateTime\Unit;
 
-class Month implements Unit
+final class Month implements Unit
 {
     /**
      * @return string

diff --git a/src/Coduo/PHPHumanizer/DateTime/Unit/Second.php b/src/Coduo/PHPHumanizer/DateTime/Unit/Second.php
@@ -4,7 +4,7 @@
 
 use Coduo\PHPHumanizer\DateTime\Unit;
 
-class Second implements Unit
+final class Second implements Unit
 {
     /**
      * @return string

diff --git a/src/Coduo/PHPHumanizer/DateTime/Unit/Week.php b/src/Coduo/PHPHumanizer/DateTime/Unit/Week.php
@@ -4,7 +4,7 @@
 
 use Coduo\PHPHumanizer\DateTime\Unit;
 
-class Week implements Unit
+final class Week implements Unit
 {
     /**
      * @return string

diff --git a/src/Coduo/PHPHumanizer/DateTime/Unit/Year.php b/src/Coduo/PHPHumanizer/DateTime/Unit/Year.php
@@ -4,7 +4,7 @@
 
 use Coduo\PHPHumanizer\DateTime\Unit;
 
-class Year implements Unit
+final class Year implements Unit
 {
     /**
      * @return string

diff --git a/src/Coduo/PHPHumanizer/Number/Ordinal.php b/src/Coduo/PHPHumanizer/Number/Ordinal.php
@@ -5,7 +5,7 @@
 use Coduo\PHPHumanizer\Number\Ordinal\Builder;
 use Coduo\PHPHumanizer\Number\Ordinal\StrategyInterface;
 
-class Ordinal
+final class Ordinal
 {
     /**
      * @var int|float

diff --git a/src/Coduo/PHPHumanizer/Number/Ordinal/Builder.php b/src/Coduo/PHPHumanizer/Number/Ordinal/Builder.php
@@ -5,7 +5,7 @@
 /**
  * Tries to find a proper  strategy for ordinal numbers.
  */
-class Builder
+final class Builder
 {
     /**
      * @param string $locale

diff --git a/src/Coduo/PHPHumanizer/Number/RomanNumeral.php b/src/Coduo/PHPHumanizer/Number/RomanNumeral.php
@@ -2,7 +2,7 @@
 
 namespace Coduo\PHPHumanizer\Number;
 
-class RomanNumeral
+final class RomanNumeral
 {
     const MIN_VALUE = 1;
     const MAX_VALUE = 3999;

diff --git a/src/Coduo/PHPHumanizer/Resources/Ordinal/EnStrategy.php b/src/Coduo/PHPHumanizer/Resources/Ordinal/EnStrategy.php
@@ -4,7 +4,7 @@
 
 use Coduo\PHPHumanizer\Number\Ordinal\StrategyInterface;
 
-class EnStrategy implements StrategyInterface
+final class EnStrategy implements StrategyInterface
 {
     /** {@inheritdoc} */
     public function ordinalSuffix($number)

diff --git a/src/Coduo/PHPHumanizer/Resources/Ordinal/NlStrategy.php b/src/Coduo/PHPHumanizer/Resources/Ordinal/NlStrategy.php
@@ -4,7 +4,7 @@
 
 use Coduo\PHPHumanizer\Number\Ordinal\StrategyInterface;
 
-class NlStrategy implements StrategyInterface
+final class NlStrategy implements StrategyInterface
 {
     /** {@inheritdoc} */
     public function ordinalSuffix($number)

diff --git a/src/Coduo/PHPHumanizer/String/BinarySuffix.php b/src/Coduo/PHPHumanizer/String/BinarySuffix.php
@@ -2,7 +2,7 @@
 
 namespace Coduo\PHPHumanizer\String;
 
-class BinarySuffix
+final class BinarySuffix
 {
     const CONVERT_THRESHOLD = 1024;
 

diff --git a/src/Coduo/PHPHumanizer/String/HtmlTruncate.php b/src/Coduo/PHPHumanizer/String/HtmlTruncate.php
@@ -2,7 +2,7 @@
 
 namespace Coduo\PHPHumanizer\String;
 
-class HtmlTruncate implements TruncateInterface
+final class HtmlTruncate implements TruncateInterface
 {
     /**
      * @var string

diff --git a/src/Coduo/PHPHumanizer/String/Humanize.php b/src/Coduo/PHPHumanizer/String/Humanize.php
@@ -2,7 +2,7 @@
 
 namespace Coduo\PHPHumanizer\String;
 
-class Humanize
+final class Humanize
 {
     /**
      * @var string

diff --git a/src/Coduo/PHPHumanizer/String/MetricSuffix.php b/src/Coduo/PHPHumanizer/String/MetricSuffix.php
@@ -2,7 +2,7 @@
 
 namespace Coduo\PHPHumanizer\String;
 
-class MetricSuffix
+final class MetricSuffix
 {
     const CONVERT_THRESHOLD = 1000;
 

diff --git a/src/Coduo/PHPHumanizer/String/ShortcodeProcessor.php b/src/Coduo/PHPHumanizer/String/ShortcodeProcessor.php
@@ -7,7 +7,7 @@
 use Thunder\Shortcode\Processor\Processor;
 use Thunder\Shortcode\Shortcode\ShortcodeInterface;
 
-class ShortcodeProcessor
+final class ShortcodeProcessor
 {
     /**
      * Removes all shortcodes from given text.

diff --git a/src/Coduo/PHPHumanizer/String/TextTruncate.php b/src/Coduo/PHPHumanizer/String/TextTruncate.php
@@ -2,7 +2,7 @@
 
 namespace Coduo\PHPHumanizer\String;
 
-class TextTruncate implements TruncateInterface
+final class TextTruncate implements TruncateInterface
 {
     /**
      * @var string

diff --git a/src/Coduo/PHPHumanizer/String/WordBreakpoint.php b/src/Coduo/PHPHumanizer/String/WordBreakpoint.php
@@ -2,8 +2,13 @@
 
 namespace Coduo\PHPHumanizer\String;
 
-class WordBreakpoint implements Breakpoint
+final class WordBreakpoint implements Breakpoint
 {
+    /**
+     * @param string $text
+     * @param int $charactersCount
+     * @return bool|int
+     */
     public function calculatePosition($text, $charactersCount)
     {
         if ($charactersCount < 0) {

diff --git a/src/Coduo/PHPHumanizer/Translator/Builder.php b/src/Coduo/PHPHumanizer/Translator/Builder.php
@@ -5,8 +5,12 @@
 use Symfony\Component\Translation\Loader\YamlFileLoader;
 use Symfony\Component\Translation\Translator;
 
-class Builder
+final class Builder
 {
+    /**
+     * @param $locale
+     * @return Translator
+     */
     public static function build($locale)
     {
         $translator = new Translator($locale);