adding some css styling to fix the div height - fixes #500 #504
Conversation
ghost
commented
Jan 9, 2017
ghost
commented
ghost
requested a review
from 
|
Layout looks good 👍 and issue is fixed when viewed in normal mode, in all three browsers (Chrome, Firefox, Safari. But when resized to different views, the images inside the page increase in size (sudden jump). This could be due to not all viewports (browser sizes have been configured via css). Haven;t check on mobile browser - hopefully it will be fine. |
| @media (min-width: 768px){ | ||
| .row.team div.col-md-2{ | ||
| height: 17vw; | ||
| } |
There was a problem hiding this comment.
minor: closing brace indentation is not in line
| @@ -1126,3 +1126,13 @@ h2.gray-underline:after { | |||
| -webkit-align-items: center; | |||
| color: #fff; | |||
| } | |||
|
|
|||
| .row.team div.col-md-2 { | |||
There was a problem hiding this comment.
Any difference defining a class like:
.fixed-image-size {
...
}
and using it in the respective places in the HTML rather how it's done here ?
There was a problem hiding this comment.
yeah, probably having a separate class would be better, not sure about the name though
|
@halimakoundi sorry we have conflicts now |
|
thanks for letting me know |
| @@ -1126,3 +1126,13 @@ h2.gray-underline:after { | |||
| -webkit-align-items: center; | |||
| color: #fff; | |||
| } | |||
|
|
|||
| .row.team div.col-md-2 { | |||
There was a problem hiding this comment.
yeah, probably having a separate class would be better, not sure about the name though
|
We had a cool chat yesterday with @halimakoundi, we're unsure how to proceed here yet, but it seems that bootstrap is doing their own media queries already to choose different css classes, e.g. |
|
please check PR #524 for an alternative solution |
ghost
closed this
